Closed
Bug 1477871
Opened 6 years ago
Closed 6 years ago
Extract the construction of nsColumnSetFrame into a helper function.
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
In nsCSSFrameConstructor, we check whether nsColumnSetFrame is needed to wrap an block frame in three different places (ConstructFieldSetFrame, ConstructFrameFromItemInternal, and ConstructBlock). It would be good to have those code extract into a helper function.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8994384 [details] Bug 1477871 - Extract the construction of nsColumnSetFrame into a helper function. Daniel Holbert [:dholbert] (PTO 7/26 - 7/30) has approved the revision. https://phabricator.services.mozilla.com/D2312
Attachment #8994384 -
Flags: review+
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cddbe5dcda33 Extract the construction of nsColumnSetFrame into a helper function. r=dholbert
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cddbe5dcda33
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•