1477960 - Port Bug 1477579: Part 3 - Avoid duplicating static strings in category manager entries

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Parameter changes for GetCategoryEntry().

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1477960-GetCategoryEntry.patch

This might do it. I'll push when the local build is done.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fd43d126a650
Port bug 1477579, part 3: changes to parameters of GetCategoryEntry(). rs=bustage-fix DONTBUILD

Comment 3

[:aceman]

Comment on attachment 8994463 [details] [diff] [review]
1477960-GetCategoryEntry.patch

Review of attachment 8994463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: mailnews/base/src/MailNewsDLF.cpp
@@ +49,5 @@
>      do_GetService(NS_CATEGORYMANAGER_CONTRACTID, &rv));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    nsAutoCString contractID;
>    rv = catMan->GetCategoryEntry("Gecko-Content-Viewers", TEXT_HTML,

So a "" string literal (TEXT_HTML) gets automatically converted to nsACString? But the m-c patch also has such cases.

Comment 4

[Jorg K (CEST = GMT+2)]

I was surprised myself ;-) - I was about to add nsDependentCString(), but it compiled without it.