Closed Bug 1477960 Opened 3 years ago Closed 3 years ago

Port Bug 1477579: Part 3 - Avoid duplicating static strings in category manager entries

Categories

(MailNews Core :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

Parameter changes for GetCategoryEntry().
This might do it. I'll push when the local build is done.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fd43d126a650
Port bug 1477579, part 3: changes to parameters of GetCategoryEntry(). rs=bustage-fix DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Version: 60 → Trunk
Comment on attachment 8994463 [details] [diff] [review]
1477960-GetCategoryEntry.patch

Review of attachment 8994463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: mailnews/base/src/MailNewsDLF.cpp
@@ +49,5 @@
>      do_GetService(NS_CATEGORYMANAGER_CONTRACTID, &rv));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    nsAutoCString contractID;
>    rv = catMan->GetCategoryEntry("Gecko-Content-Viewers", TEXT_HTML,

So a "" string literal (TEXT_HTML) gets automatically converted to nsACString? But the m-c patch also has such cases.
Attachment #8994463 - Flags: review+
I was surprised myself ;-) - I was about to add nsDependentCString(), but it compiled without it.
You need to log in before you can comment on or make changes to this bug.