Closed Bug 1478136 Opened 6 years ago Closed 6 years ago

Support unlinking specific CacheIR Stubs

Categories

(Core :: JavaScript Engine: JIT, enhancement)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox63 --- affected

People

(Reporter: mgaudet, Unassigned)

References

Details

As part of the conversion to CacheIR ongoing in Bug 1438727 the arithmetic stubs will lose the ability unlink specific stubs when a more general stub applies (for example https://searchfox.org/mozilla-central/rev/bdfd20ef30d521b57d5b6feeda71325e8b4cad66/js/src/jit/SharedIC.cpp#843-845) 

It would be good to rebuild that functionality for CacheIR. It's a little harder, because the unlink system that exists is built based on Stub Kind; however all regular CacheIR stubs share the ICStubkind::CacheIR_Regular.
IMO this is probably not worth the complexity. I added it to the old code because it was easy to do, but the CacheIR version would likely be more complicated and I'd be fine dropping this "feature" for the sake of simplicity.
I'm OK with leaving it as is then. 

I'll close this out. 

Once we have a better story around the call ICs, we can then perhaps even strip the unlinkStubsWithKind infrastructure.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.