Merge GeckoChildProcessHost::PerformAsyncLaunchInternal back into PerformAsyncLaunch

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P2
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Bug 534764 split out most of GeckoChildProcessHost::PerformAsyncLaunch into PerformAsyncLaunchInternal, but as of bug 1390736 there's exactly one call site and it could be re-inlined.  There are already a lot of different methods with very similar names involved in launching processes, so one fewer would be nice.
I wrote a patch for this while I was working on bug 1446161.
Blocks: 1446161
Comment on attachment 9008595 [details]
Bug 1478145 - Merge GeckoChildProcessHost::PerformAsyncLaunchInternal back into PerformAsyncLaunch

Andrew McCreight [:mccr8] has approved the revision.
Attachment #9008595 - Flags: review+

Comment 4

8 months ago
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/287583535a97
Merge GeckoChildProcessHost::PerformAsyncLaunchInternal back into PerformAsyncLaunch r=mccr8

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/287583535a97
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.