1478225 - Changes to scrollbar color properties don't trigger repaint for viewport

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

Probably calc difference isn't enough for propagated properties :/

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Per discussion with heycam on IRC, probably we should add some code to ApplyRenderingChangeToTree.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1478225 - Always propagate repaint change hint from html/body element to viewport frame.

Generally there isn't really much difference for painting on html/body
element vs. viewport, so it's probably not worth finer grained control
over when we should propagate and when not.

Review commit: https://reviewboard.mozilla.org/r/259532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259532/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8995051 [details]
Bug 1478225 - Always propagate repaint change hint from html/body element to viewport frame.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259532/diff/1-2/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8995051 [details]
Bug 1478225 - Always propagate repaint change hint from html/body element to viewport frame.

https://reviewboard.mozilla.org/r/259532/#review267486

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e992e946488d
Always propagate repaint change hint from html/body element to viewport frame. r=heycam

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e992e946488d