1478234 - Enable client/debugger/test/mochitest/browser_dbg_globalactor.js in e10s

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Tests skipped in e10s are no longer running and should be enabled or removed.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1478234 - Enable client/debugger/test/mochitest/browser_dbg_globalactor.js in e10s.

Review commit: https://reviewboard.mozilla.org/r/260512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260512/

Comment 2

[Alexandre Poirot [:ochameau]]

try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=5afa1ee8e8f3d925307f78773c17c74fca413388

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8996398 [details]
Bug 1478234 - Enable client/debugger/test/mochitest/browser_dbg_globalactor.js in e10s.

https://reviewboard.mozilla.org/r/260512/#review267730

::: devtools/client/debugger/test/mochitest/browser_dbg_globalactor.js:56
(Diff revision 1)
> -          }
> +  }
>  
> -          is(count, 1,
> +  is(count, 1,
> -            "Only one actor exists in all pools. One global actor.");
> +    "Only one actor exists in all pools. One global actor.");
>  
> -          gClient.close().then(finish);
> +  client.close();

should we `await client.close();` here? The test seems to run fine without it though.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8996398 [details]
Bug 1478234 - Enable client/debugger/test/mochitest/browser_dbg_globalactor.js in e10s.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260512/diff/1-2/

Comment 5

[Alexandre Poirot [:ochameau]]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> should we `await client.close();` here? The test seems to run fine without
> it though.

It is better to wait, so I added the `await`!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be05373dce92
Enable client/debugger/test/mochitest/browser_dbg_globalactor.js in e10s. r=jdescottes

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/be05373dce92