1478331 - should nightly-asan-reporter builds use "nightly" branding instead of "unofficial"?

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Julien Cristau [:jcristau]]

I've noticed that some prefs differ between the nigthly-asan and regular nightly builds, that afaict are related to using browser/branding/unofficial instead of browser/branding/nightly.  Is that what we want?  E.g. regular nightly checks for updates more often, and has a firstrun and whatsnew page setting.

Comment 1

[Kim Moir [:kmoir] ET]

The nightly branding is not specified in the mozconfig for nightly asan builds so it defaults to the unofficial branding.  I'm not sure what the requirements are to use nightly branding, will find out.

Comment 2

[Kim Moir [:kmoir] ET]

:pdol do you have any objections to using the nightly branding in nightly asan builds?

Comment 3

[Peter Dolanjski [:pdol]]

No objection.  My only concern is around having users not know this is the build they have, so as long as we don't have ways for users to get this version that aren't obviously labeled as a special build, I think using branding is fine.

Comment 4

[Julien Cristau [:jcristau]]

Attachment: Bug 1478331 - use nightly branding for ASan Nightly builds. r?firefox-build-system-reviewers

Comment 5

[Julien Cristau [:jcristau]]

Attachment: Bug 1478331 - Include common-opt mozconfig from nightly-asan-reporter instead of duplicating much of it. r?dmajor

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09fafd3deae
use nightly branding for ASan Nightly builds. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/b919062c2b51
Include common-opt mozconfig from nightly-asan-reporter instead of duplicating much of it. r=dmajor

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b09fafd3deae
https://hg.mozilla.org/mozilla-central/rev/b919062c2b51