147841 - Error: warnCheckbox has no properties

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Brant Gurganus]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0+)
Gecko/20020528
BuildID:    2002052809

There is a an Error: warnCheckbox has no properties error in the JavaScript
Console when I use the Privacy > Images preferences.

Reproducible: Always
Steps to Reproduce:
1. Open preferences.
2. Expand Privacy & Security.
3. Click Images.

Actual Results:  An error appears in the JavaScript console:

Error: warnCheckbox has no properties
Source File: chrome://cookie/content/pref-images.xul
Line: 71

Expected Results:  There should be no error.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

CCing people responsible for introducing this minor regression.

Comment 3

[Alec Flett]

Comment on attachment 85432 [details] [diff] [review]
Proposed patch

fix this the right way, don't just comment out the offending code.

all you needed to do was put a 

if (!warnCheckbox) return;

Comment 4

[[e-mail]]

Comment on attachment 85432 [details] [diff] [review]
Proposed patch

alecf: I did it that way to match the previous comment that caused the
regression.

Comment 5

[Brant Gurganus]

This appears to be fixed in 2002060616 on Windows XP Home Edition.

Comment 6

[[e-mail]]

Fix is in bug 97055.