Closed
Bug 1478416
Opened 7 years ago
Closed 7 years ago
tc-client-web retries 4xx errors, making signin take longer
Categories
(Taskcluster :: UI, enhancement)
Taskcluster
UI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
()
Details
Attachments
(1 file)
|
107.27 KB,
image/png
|
Details |
Screenshot from 2018-07-25 12-18-35.png
When signing in, the UI code looks for an unused clientId, and does so by probing until it finds one that returns 404.
But tc-client-web retries 4xx errors, so this means that finding that 404 requires several seconds, including backoff, before the error is propagated to the caller.
Clients should only retry 5xx errors, anyway -- that's the behavior of the other client libraries. So I think doing the same in tc-client-web would both help UI performance, reduce load on services, and be the right thing to do..
|
||
Updated•7 years ago
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dustin
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/taskcluster/taskcluster-tools
https://github.com/taskcluster/taskcluster-tools/commit/eff4af2ac82ab5036d12a888180be59a0075866a
Bug 1478416 - upgrade tc-client-web to stop 4xx retries
|
|
Assignee | |
Comment 4•7 years ago
|
||
Yay, signin is way faster now!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Tools → UI and Tools
You need to log in
before you can comment on or make changes to this bug.
Description
•