Closed Bug 1478448 Opened Last year Closed 11 months ago

Track Changes - Add Changes panel to Inspector and config Redux store

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 4 obsolete files)

46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review
46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review
46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review
46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review
46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review
This adds:
- a new pref for the Track Changes feature: devtools.inspector.changes.enabled
- the basic Redux store config, basic actions and reducers
- the Changes panel and basic React - Redux setup
- a ChangeManager class responsible for populating the Redux store
- a prototype client-side implementation for tracking changes to ensure all of the above work (this may be removed in future patches).
Blocks: 1478612
Attachment #8994950 - Attachment is obsolete: true
Attachment #8994950 - Flags: review?(gl)
Attachment #8994951 - Attachment is obsolete: true
Attachment #8994951 - Flags: review?(gl)
> - a prototype client-side implementation for tracking changes to ensure all of the above work (this may be removed in future patches).

Moved the patch for client-side tracking to its own bug (Bug 1478612) which depends on this one.
Attachment #8994948 - Flags: review?(gl)
Attachment #8994949 - Flags: review?(gl)
Attachment #8994950 - Flags: review?(gl)
Comment on attachment 8994948 [details]
Bug 1478448 - (Part 1) Add pref for enabling the Track Changes feature.

https://reviewboard.mozilla.org/r/259444/#review269420

Only a nit about the name, but feel free to not change it, it's not important at all

::: devtools/client/preferences/devtools-client.js:73
(Diff revision 1)
>  // Enable the Variable Fonts editor
>  pref("devtools.inspector.fonteditor.enabled", false);
>  // Enable the font highlight-on-hover feature
>  pref("devtools.inspector.fonthighlighter.enabled", false);
> +// Enable tracking of style changes and the Changes panel in the Inspector
> +pref("devtools.inspector.changes.enabled", false);

nit: could we name it trackchanges so it's more obvious ?
Attachment #8994948 - Flags: review+
MozReview-Commit-ID: 3liB2MyJQ21
Attachment #8994949 - Attachment is obsolete: true
Attachment #8994950 - Attachment is obsolete: true
Attachment #8994948 - Attachment is obsolete: true
MozReview-Commit-ID: 4AzKdXuq6rX
Comment on attachment 8999914 [details]
Bug 1478448 - (Part 1) Add pref for Track Changes feature. r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999914 - Flags: review+
Attachment #8999919 - Attachment description: Bug 1478448 - (Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbeDepends on D3326 → Bug 1478448 - (Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe Depends on D3326
Comment on attachment 8999916 [details]
Bug 1478448 - (Part 2) Add basic Redux actions and reducers for Track Changes. r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999916 - Flags: review+
Comment on attachment 8999919 [details]
Bug 1478448 - (Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999919 - Flags: review+
Attachment #8999916 - Attachment description: Bug 1478448 - (Part 2) Add basic Redux actions and reducers for Track Changes. r=nchevobbeDepends on D3326 → Bug 1478448 - (Part 2) Add basic Redux actions and reducers for Track Changes. r=nchevobbe
Attachment #8999919 - Attachment description: Bug 1478448 - (Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe Depends on D3326 → Bug 1478448 - (Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe
Attachment #8999920 - Attachment description: Bug 1478448 - (Part 4) Render tracked style changes. r=nchevobbeDepends on D3326 → Bug 1478448 - (Part 4) Render tracked style changes. r=nchevobbe
Attachment #8999921 - Attachment description: Bug 1478448 - (Part 5) Add ChangeManager skeleton to pass tracked style changes to store. r=nchevobbeDepends on D3326 → Bug 1478448 - (Part 5) Add ChangeManager skeleton to pass tracked style changes to store. r=nchevobbe
Comment on attachment 8999920 [details]
Bug 1478448 - (Part 4) Render tracked style changes. r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999920 - Flags: review+
Comment on attachment 8999921 [details]
Bug 1478448 - (Part 5) Add ChangeManager skeleton to pass tracked style changes to store. r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999921 - Flags: review+
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57b2bb7a6565
(Part 1) Add pref for Track Changes feature. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/cc33bc63f405
(Part 2) Add basic Redux actions and reducers for Track Changes. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/775ad6690aa8
(Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8ecc1050fdfc
(Part 4) Render tracked style changes. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/1ece57c66cc8
(Part 5) Add ChangeManager skeleton to pass tracked style changes to store. r=nchevobbe
Backed out for devtools failures on browser_parsable_css.js 

backout: https://hg.mozilla.org/integration/autoland/rev/e20a7e1afcd7a52c9ceb7588090a89b72684d51f

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1ece57c66cc83b56117b2a439ad4023cfedf0704

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=199717433&repo=autoland&lineNumber=2307

[task 2018-09-17T16:05:12.682Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 631}]
[task 2018-09-17T16:05:12.684Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 635}]
[task 2018-09-17T16:05:12.689Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 639}]
[task 2018-09-17T16:05:12.690Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 645}]
[task 2018-09-17T16:05:12.698Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 650}]
[task 2018-09-17T16:05:12.699Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 655}]
[task 2018-09-17T16:05:12.700Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." {file: "resource://devtools/server/actors/highlighters.css?always-parse-css-0.2152034871866103" line: 662}]
[task 2018-09-17T16:05:12.701Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown property ‘-moz-border-radius’.  Declaration dropped." {file: "chrome://devtools/content/sourceeditor/codemirror/lib/codemirror.css?always-parse-css-0.2152034871866103" line: 241}]
[task 2018-09-17T16:05:12.702Z] 16:05:12     INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’.  Declaration dropped." {file: "resource://devtools/client/shared/components/reps/reps.css" line: 23}]
[task 2018-09-17T16:05:12.703Z] 16:05:12     INFO - Buffered messages logged at 16:05:12
[task 2018-09-17T16:05:12.704Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools-client-shared/components/reps/reps.css because of whitelist item {"sourceName":"/devtools-client-shared\\/components\\/reps\\/reps.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.705Z] 16:05:12     INFO - Buffered messages finished
[task 2018-09-17T16:05:12.706Z] 16:05:12     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://devtools/skin/changes.css: Unknown property ‘user-select’.  Declaration dropped. - 
[task 2018-09-17T16:05:12.707Z] 16:05:12     INFO - Stack trace:
[task 2018-09-17T16:05:12.708Z] 16:05:12     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:247
[task 2018-09-17T16:05:12.709Z] 16:05:12     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:446
[task 2018-09-17T16:05:12.709Z] 16:05:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1102
[task 2018-09-17T16:05:12.710Z] 16:05:12     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
[task 2018-09-17T16:05:12.711Z] 16:05:12     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
[task 2018-09-17T16:05:12.712Z] 16:05:12     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-09-17T16:05:12.713Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.714Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.715Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.717Z] 16:05:12     INFO - Ignored error "Unknown property ‘appearance’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.718Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.719Z] 16:05:12     INFO - Ignored error "Error in parsing value for ‘display’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.722Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
[task 2018-09-17T16:05:12.723Z] 16:05:12     INFO - Ignored error "Unknown property ‘user-select’.  Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true}
Flags: needinfo?(rcaliman)
Removed unrecognized 'user-select' CSS property and pushing again.
Flags: needinfo?(rcaliman)
Keywords: leave-open
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca9f67bd0a57
(Part 1) Add pref for Track Changes feature. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/3958a624af3e
(Part 2) Add basic Redux actions and reducers for Track Changes. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0ae564c9888a
(Part 3) Add Track Changes sidebar panel in Inspector. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f6942e5fdf2a
(Part 4) Render tracked style changes. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a38ec78617f8
(Part 5) Add ChangeManager skeleton to pass tracked style changes to store. r=nchevobbe
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.