1478540 - Update User.pm to load more than 100 users by using the paging functionality of Conduit API

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Description

[David Lawrence [:dkl]]

I have figure out that the reason that group syncing has not been working as designed as the Conduit API has a 100 entry limit for Conduit API requests. If more than 100 results are desired, you have to make multiple API calls, getting 100 results each time and then combining into a full list.

https://github.com/phacility/phabricator/blob/master/src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php#L519

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Do you need the full list at once, or could you make match() return an iterator?

Comment 2

[David Lawrence [:dkl]]

Attachment: github pr #675

Comment 3

[David Lawrence [:dkl]]

(In reply to Dylan Hardison [:dylan] (he/him) from comment #1)
> Do you need the full list at once, or could you make match() return an
> iterator?

right now i was working under the assumption that any calling code will assume that all matching results will always be returned no matter how many. 

If the calling code wanted all results, it would have to be smart enough to keep making calls til all results are gathered. Right now none of the PhabBugz code works in that way and just needs everything. So I thought better to just put the login in one place for now, User->match().

Comment 4

[David Lawrence [:dkl]]

This patch also fixed the call to diff_arrays where the values are arguments were in the wrong order.\

Merged to master.