Closed Bug 1478563 Opened 6 years ago Closed 6 years ago

Optimize MeatballMenu

Categories

(DevTools :: General, enhancement, P2)

Product:
DevTools
Component:
General
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1478563 - Re-use function objects in MeatballMenu; r=jdescottes
46 bytes, text/x-phabricator-request
jdescottes
: review+
Details | Review
See bug 1472938 comment 25. Specifically: * Re-use the same function object for various component props to avoid needless re-renders * Set a key on the various items.
Priority: -- → P2
To avoid needless re-renders due to props changing object identity. Depends on DNone
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 8996905 [details] Bug 1478563 - Re-use function objects in MeatballMenu; r=jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision. https://phabricator.services.mozilla.com/D2641
Attachment #8996905 - Flags: review+
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d4ca2c8982af Re-use function objects in MeatballMenu; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/d4ca2c8982af
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: