1478614 - Scrolling to the bottom of a page with a fixed header, so that the UI bar reappears, breaks touch position.

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Testcase

First seen on https://mozilla.logbot.info
Somewhat simplified testcase attached and at http://kwan.perix.co.uk/mozilla/touchPosTest.html

STR:
1) Open affected page
2) Scroll down until the UI autohides
3) Keep scrolling until reaching the bottom and the UI autoshows
4) Try touching on page, especially the two sets of letters

AR:
Client position (blue circle) of the click event is wrong
Clicking on the letters on the left (in a fixed position element) Firefox targets/highlights those under the incorrect client (blue) position, which will be the letter below the clicked on one
Clicking on the letters on the right it correctly targets under the page (red) position

ER:
Client and page position match
Clicking on letters highlights the clicked on one

[Tracking Requested - why for this release]:
Poor & confusing user experience on some mobile pages if user scrolls to the page end and tries to click on any fixed-position elements.

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

This seems to have been a regression from bug 1423011.
It's also possible bug 1465616 is meant to fix this, and this'll end up duped there.

Comment 2

[Firefox Bug Husbandry Bot]

Closing per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Contact :susheel if you think this bug should be re-opened

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

:susheel is ambiguous, bringing up no results with that IRC nick on bugzilla (and no-one in either #bmo or #mobile), and 5 people who include that in their name, none of whom have an official looking address.

Fresh user-impacting regressions don't seem like a good candidate for resolving, reopening.

Comment 4

[David Durst [:ddurst]]

Reopened. Can we find an owner for this?

Comment 5

[:sdaswani]

Andreas, should I have the Softvision dev team take a look at this?

Ian, I think Emma made a small error in her closing message - I'm :sdaswani :) . One point of Emma's mass closing was to get live issues prioritized by messages like yours.

Comment 6

[Andreas Bovens [:abovens]]

I cannot reproduce the touch issue in GeckoView, only in Fennec (from time to time).

However, I do notice that the right column of letters is positioned differently in Chrome: the "a" is shown inside the light blue area, whereas in Firefox it stops just below it. It would be good to get this investigated.

Comment 7

[David Durst [:ddurst]]

Looks like abovens could reproduce; whether we want QA to take a stab at it also is up to you. Either way, we need an owner for this.

Comment 8

[Ian Moody [:Kwan] (UTC+1)]

kashav, is bug 1465616 going to fix this?

Comment 9

[Ian Moody [:Kwan] (UTC+1)]

(In reply to :sdaswani only needinfo from comment #5)
> Andreas, should I have the Softvision dev team take a look at this?
> 
> Ian, I think Emma made a small error in her closing message - I'm :sdaswani
> :) . One point of Emma's mass closing was to get live issues prioritized by
> messages like yours.

No problem :)  I was trying to ask first about reopening, but defaulted to doing so on failure to find contact.

(In reply to Andreas Bovens [:abovens] from comment #6)
> I cannot reproduce the touch issue in GeckoView, only in Fennec (from time
> to time).

What does GeckoView mean in this context?  Is there a Fx4A build with it?  Or were you using Fenix or FocusGV?  If so Fenix doesn't hide its UI, and Focus doesn't auto-unhide UI on reaching the bottom of the page, so neither would be able to trigger the issue.

Comment 10

[u608768]

(In reply to Ian Moody [:Kwan] (UTC+0) from comment #8)
> kashav, is bug 1465616 going to fix this?

It fixes it, but I'm not entirely sure why just yet (going to look into it more, will comment here with what I find).

I did find a regression caused by bug 1465616 with your testcase, so thanks for that! It's related to fixed position elements disappearing when the dynamic toolbar reappears at the bottom of the page - I'll file a bug for this.

Comment 11

[Stefan Deiac]

Based on comment 10 I will close this issue as WFM, thanks.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

No need to track this for 63.