Closed Bug 1478652 Opened 6 years ago Closed 6 years ago

removeTabs passes bogus options object to removeTab

Categories

(Firefox :: Tabbed Browser, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: ablayelyfondou)

References

Details

Attachments

(1 file)

removeTabs passes {animation: true} to removeTab. removeTab only supports an "animate" option.
Flags: needinfo?(ablayelyfondou)
Flags: needinfo?(ablayelyfondou)
Assignee: nobody → ablayelyfondou
Comment on attachment 8995693 [details]
Bug 1478652 - removeTabs passes '{animate: true}' instead of '{animation: true}' options object to removeTab in tabbrowser.js file.

https://reviewboard.mozilla.org/r/260080/#review267120
Attachment #8995693 - Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1dfe3f8eda4
removeTabs passes '{animate: true}' instead of '{animation: true}' options object to removeTab in tabbrowser.js file. r=jaws
https://hg.mozilla.org/mozilla-central/rev/f1dfe3f8eda4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.