1478652 - removeTabs passes bogus options object to removeTab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P2)

Description

[Dão Gottwald [:dao]]

removeTabs passes {animation: true} to removeTab. removeTab only supports an "animate" option.

Comment 1

[Abdoulaye O. LY]

Attachment: Bug 1478652 - removeTabs passes '{animate: true}' instead of '{animation: true}' options object to removeTab in tabbrowser.js file.

Review commit: https://reviewboard.mozilla.org/r/260080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260080/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995693 [details]
Bug 1478652 - removeTabs passes '{animate: true}' instead of '{animation: true}' options object to removeTab in tabbrowser.js file.

https://reviewboard.mozilla.org/r/260080/#review267120

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1dfe3f8eda4
removeTabs passes '{animate: true}' instead of '{animation: true}' options object to removeTab in tabbrowser.js file. r=jaws

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f1dfe3f8eda4