1478669 - AddonRepository parsing does not match platform correctly.

Status: RESOLVED DUPLICATE of bug 1476177

(Firefox :: General, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

While building and example test case for about:welcome, I discovered that source urls for downloading extensions were not avialble.  It turns out that the AMO api returns "mac" for the platform and compares it against Services.appinfo.OS which returns "darwin" thus failing to find a compatible platform download.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1478669 - Fix addon data parsing for mac,

AMO returns "mac" but the parsing ended up using "darwin".
To test I also hack up the test environment appInfo, since
it sets the platform to XPCShell.

Review commit: https://reviewboard.mozilla.org/r/259712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259712/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8995238 [details]
Bug 1478669 - Fix addon data parsing for mac,

https://reviewboard.mozilla.org/r/259712/#review266718

we need to handle linux and windows too.

Comment 4

[Shane Caraveo (:mixedpuppy)]

(In reply to Andrew Swan [:aswan] from comment #2)
> Comment on attachment 8995238 [details]
> Bug 1478669 - Fix addon data parsing for mac,
> 
> https://reviewboard.mozilla.org/r/259712/#review266718
> 
> we need to handle linux and windows too.

windows, linux and android match.  It's just darwin != mac.

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> (In reply to Andrew Swan [:aswan] from comment #2)
> > Comment on attachment 8995238 [details]
> > Bug 1478669 - Fix addon data parsing for mac,
> > 
> > https://reviewboard.mozilla.org/r/259712/#review266718
> > 
> > we need to handle linux and windows too.
> 
> windows, linux and android match.  It's just darwin != mac.

heh, maybe not.  I tested on windows, it returned windows.  but maybe it is version specific.