Memory leak in LCovRealm/LCovCompartment

RESOLVED FIXED in Firefox -esr60

Status

()

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: ptomato, Assigned: ptomato)

Tracking

60 Branch
mozilla63
Points:
---

Firefox Tracking Flags

(firefox-esr60 fixed, firefox63 fixed)

Details

Attachments

(2 attachments)

There's a placement-new without a corresponding destructor call in LCovRealm (LCovCompartment in the esr60 branch) which ASAN and Valgrind complain about if you call js::GetCodeCoverageSummary().

I'll attach a patch, as well as a proposal to backport to esr60.
Patch for trunk
Attachment #8995222 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → philip.chimento
Status: NEW → ASSIGNED
ESR60 version of patch
Attachment #8995228 - Flags: review?(nicolas.b.pierron)
Attachment #8995228 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8995222 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8995222 - Flags: checkin?
Keywords: checkin-needed
Comment on attachment 8995228 [details] [diff] [review]
Fix memory leak in LCovCompartment (ESR60 version)

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's a memory leak.
User impact if declined: Using this API will continue to leak memory (it was a regression somewhere in between 52 and 60.) Although the API is not used in Firefox proper; it's more likely that memory is leaking in Firefox's dev tools.
Fix Landed on Version: 63
Risk to taking this patch (and alternatives if risky): Low risk, the fix is not invasive.
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8995228 - Flags: approval-mozilla-esr60?
Note that on ESR60 with GCC 8.1.0, strangely only with this patch, I run into the GCC crash reported on bug 1458382. So I'll request uplift for that patch as well.
https://hg.mozilla.org/mozilla-central/rev/50c5b8fb4e75
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Attachment #8995222 - Flags: checkin? → checkin-
Comment on attachment 8995228 [details] [diff] [review]
Fix memory leak in LCovCompartment (ESR60 version)

Fixes a memory leak in Spidermonkey 60. Approved for ESR 60.2.
Attachment #8995228 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.