1478679 - Memory leak in LCovRealm/LCovCompartment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Philip Chimento [:ptomato]]

There's a placement-new without a corresponding destructor call in LCovRealm (LCovCompartment in the esr60 branch) which ASAN and Valgrind complain about if you call js::GetCodeCoverageSummary().

I'll attach a patch, as well as a proposal to backport to esr60.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: Fix memory leak in LCovRealm

Patch for trunk

Comment 2

[Philip Chimento [:ptomato]]

Attachment: Fix memory leak in LCovCompartment (ESR60 version)

ESR60 version of patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50c5b8fb4e75
Fix memory leak in LCovRealm. r=nbp

Comment 4

[Philip Chimento [:ptomato]]

Comment on attachment 8995228 [details] [diff] [review]
Fix memory leak in LCovCompartment (ESR60 version)

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: It's a memory leak.
User impact if declined: Using this API will continue to leak memory (it was a regression somewhere in between 52 and 60.) Although the API is not used in Firefox proper; it's more likely that memory is leaking in Firefox's dev tools.
Fix Landed on Version: 63
Risk to taking this patch (and alternatives if risky): Low risk, the fix is not invasive.
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 5

[Philip Chimento [:ptomato]]

Note that on ESR60 with GCC 8.1.0, strangely only with this patch, I run into the GCC crash reported on bug 1458382. So I'll request uplift for that patch as well.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/50c5b8fb4e75

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8995228 [details] [diff] [review]
Fix memory leak in LCovCompartment (ESR60 version)

Fixes a memory leak in Spidermonkey 60. Approved for ESR 60.2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/0c461b367f8e