1478686 - Pressing TAB when focused on the reveal link moves focus outside of selected node

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Julian Descottes [:jdescottes]]

From bug 1460613:

(In reply to ovidiu boca[:Ovidiu] from bug 1460613 comment #15)
> I tested this with Nightly 63.0a1(2018-07-26) and I have a question related
> to the Tab key functionality. If I click on the <div> element and then I
> press the Tab key the focus is moved, but if I press again on Tab key the
> focus is moved to the bottom, not to the next <div>. 
> I think when you press Tab key the focus should go from one <div> to the
> next one. Please see the video for a better understanding:
> https://streamable.com/1p0kd
> Please tell me your opinion.

(In reply to Julian Descottes [:jdescottes][:julian] from bug 1460613 comment #16)
> I think to be consistent with the rest of the markupview, the focus should
> remain in the same line (and not got to the next one, or go to "more nodes"
> or go to the breadcrumbs). Indeed a bug.

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1478686 - Fix cycling focus with keyboard on slotted nodes. r=jdescottes

Comment 2

[Phabricator Automation]

Comment on attachment 8996723 [details]
Bug 1478686 - Fix cycling focus with keyboard on slotted nodes.
r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

https://phabricator.services.mozilla.com/D2605

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73168a753636
Fix cycling focus with keyboard on slotted nodes. r=jdescottes

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/73168a753636

Comment 5

[ovidiu boca[:Ovidiu]]

I verified this issue on Mac OS X 10.12, Ubuntu 16.04 and Windows 10 x64 with the latest FF Nightly 63.0a1(2018-08-19) and I can confirm the fix.

Comment 6

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 63.0a1 (2018.07.26) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 63.0b4 on Ubuntu 16.04 x64, Windows  10 x64 and Mac OS X 10.13.