Closed Bug 1478743 Opened 6 years ago Closed 6 years ago

Fix some standards compliance issues with XHR

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(3 files)

I was in this code for unrelated reasons and saw some things that were a bit broken...  fixes coming up.
Most of the change is just making the responseType wpt run on workers and
annotating the resulting failures.

The change to the initial value of mResponseType is a drive-by fix for an
easy-to-fix issue the test caught.  There is a corresponding mochitest fix to
fix our incorrect test for the behavior.
Attachment #8995327 - Flags: review?(amarchesini)
Attachment #8995327 - Flags: review?(amarchesini) → review+
Attachment #8995328 - Flags: review?(amarchesini) → review+
Attachment #8995329 - Flags: review?(amarchesini) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/565222693850
part 1.  Add some test coverage for setting xhr.responseType on workers.  r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e2e905fdb24
part 2.  Add some test coverage for calling xhr.overrideMimeType() in done state in workers.  r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4dd832985c
part 3.  Remove bogus clearing of the response when xhr.overrideMimeType throws.  r=baku
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12232 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: