Closed Bug 1478744 Opened 7 years ago Closed 7 years ago

Add security UI notifications when fastblock decides to block something

Categories

(Core :: Networking, enhancement, P3)

Product:
Core
Component:
Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: ehsan.akhgari, Assigned: xeonchen)

References

Details

(Whiteboard: [necko-triaged])

Right now the feature implemented in bug 1474280 doesn't notify the Security UI about what's happening in terms of connections being blocked, so the UI doesn't have a chance to notify the user in any way. For an example of how to do this, you can look at bug 1475697. Gary, can you please take this one too?
Flags: needinfo?(xeonchen)
Severity: normal → critical
Priority: -- → P1
We need to know when a slow trackers is detected, when no slow trackers are detected, and when a slow tracker is detected and blocked.
There is currently no detect only mode, we only block.
(In reply to (PTO, back on Aug 8th) from comment #0) > Right now the feature implemented in bug 1474280 doesn't notify the Security > UI about what's happening in terms of connections being blocked, so the UI > doesn't have a chance to notify the user in any way. > > For an example of how to do this, you can look at bug 1475697. > > Gary, can you please take this one too? Thanks for the example, I'll take this.
Assignee: nobody → xeonchen
Flags: needinfo?(xeonchen)
Whiteboard: [necko-triaged]
Johann, could you comment on this bug?
Flags: needinfo?(jhofmann)
We probably don't need to do this. The new content blocking UI (getting introduced in bug 1476218) does not differentiate between webrequest flags for blocked/loaded trackers anymore, instead it considers a single loaded OR blocked (now called "detected") tracker reason enough to show the shield and the content blocking UI. Then, we figure out which mechanism (FastBlock or TP) is turned on by looking at the respective prefs and show them as active. We simply trust that the behavior from Necko is in accordance with these prefs and that e.g. if TP is enabled no "loaded" tracker notification should arrive (anything else would be a bug). Thus, FastBlock is already correctly displayed in the UI after bug 1476218 after which we can probably resolve this bug as WORKSFORME. Let me know if I'm missing something.
Depends on: 1476218
Flags: needinfo?(jhofmann)
I'll lower the priority for now based on Johann's comment. Ehsan, do you agree with comment 5?
Severity: critical → normal
Flags: needinfo?(ehsan)
Priority: P1 → P3
(In reply to Ethan Tseng [:ethan] from comment #6) > I'll lower the priority for now based on Johann's comment. > > Ehsan, do you agree with comment 5? Yes, that sounds reasonable.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ehsan)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.