1478751 - Instances of AutoSuppressGCAnalysis in JS::ubi::Concrete<nsINode> need to be cleaned up

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[Kris Wright :KrisWright]

Instances like DocAddSizeOfIncludingThis() called in JS::ubi::Concrete<nsINode> and inheriting classes are seen as potential GC hazards. In the interim, AutoSuppressGCAnalysis objects are used to prevent hazards. We want to clean up these instances by adding an exception for DocAddSizeOfExcludingThis in isOverridableField in annotations.js [1], and address other instances of AutoSuppressGCAnalysis in JS::ubi::Concrete<nsINode> and JS::ubi::Concrete<JSObject> [2].

1. https://searchfox.org/mozilla-central/rev/943a6cf31a96eb439db8f241ab4df25c14003bb8/js/src/devtools/rootAnalysis/annotations.js#385

2. See Bug 1474383

Comment 1

[Jason Orendorff [:jorendorff]]

Kristen, are you interested in working on this?

Comment 2

[Kris Wright :KrisWright]

Looks like since the filing of this bug some other related rooting analysis issues have been cleaned up so it's definitely worth checking back into. I'll see if I can reduce the volume of AutoSuppressGCAnalysis in NodeUbiReporting.cpp. Right now there's four instances of AutoSuppressGCAnalysis across the JS::ubi::Concrete<JSObject>/JS::ubi::Concrete<nsINode> hook that could potentially be cleaned up.