1478754 - WebGL crash when webgl.enable-surface-texture is enabled on Android

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Imanol Fernandez]

We can reproduce this crash in Firefox Reality using GeckoView

STR

Enable webgl.enable-surface-texture
Load https://developer.playcanvas.com/en/tutorials/webvr-lab/
Crashes on the MOZ_RELEASE_ASSERT(mSurface->GetAvailable()) in  SharedSurface_SurfaceTexture::Commit()

Comment 1

[Imanol Fernandez]

I'm going to submit a patch soon

Comment 2

[Imanol Fernandez]

Attachment: Bug 1478754 - WebGL crash when webgl.enable-surface-texture is enabled on Android;

Review commit: https://reviewboard.mozilla.org/r/259780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259780/

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8995320 [details]
Bug 1478754 - WebGL crash when webgl.enable-surface-texture is enabled on Android;

https://reviewboard.mozilla.org/r/259780/#review266806

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8995320 [details]
Bug 1478754 - WebGL crash when webgl.enable-surface-texture is enabled on Android;

https://reviewboard.mozilla.org/r/259780/#review267104

Change the patch summary line to reflect what's being fixed in the code, not what the repro case is. Repro info should go in the summary block below the bug line.

Comment 5

[Imanol Fernandez]

Comment on attachment 8995320 [details]
Bug 1478754 - WebGL crash when webgl.enable-surface-texture is enabled on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259780/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34388a2acea8
WebGL crash when webgl.enable-surface-texture is enabled on Android; r=jgilbert,rbarker

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/34388a2acea8

Comment 8

[Kelsey Gilbert [:jgilbert]]

In the future, this is what I'd like to see for a patch summary:

> Don't composite from SharedSurface_SurfaceTexture until the surface is Available.

The goal here is to tell the reader at a glance what the patch actually changes, not what symptoms it fixes.

(ni for fyi)

Comment 10

[Imanol Fernandez]

Thanks, I'll use that style for future commits. I understood that the PlayCanvas mention was the problem, not the "Fix WebGL crash" style :)

Comment 11

[Chris Peterson [:cpeterson]]

Imanol, could this WebGL crash affect GeckoView in other apps like Focus? Should we uplift your fix to GeckoView 62 for Focus?

SharedSurface_SurfaceTexture::Commit() is the #2 top crash in GeckoView 62 Beta. IIUC, FxR is using GeckoView 63 Nightly and Focus Nightly is using GeckoView 62 Beta, so these GeckoView 62 crashes are probably Focus. Nearly of these crash reports point to video crashes.

https://crash-stats.mozilla.com/signature/?product=FennecAndroid&_sort=-date&process_type=content&version=62.0b&signature=mozilla%3A%3Agl%3A%3ASharedSurface_SurfaceTexture%3A%3ACommit&date=%3E%3D2018-07-27T15%3A48%3A15.000Z&date=%3C2018-08-03T15%3A48%3A15.000Z

Comment 12

[Imanol Fernandez]

Chris, yes I think that this patch could fix the #2 top crash in GeckoView. The crash happened during a normal webpage load, not while in WebVR, so it should help with Focus/GV crashes too.

Comment 13

[Chris Peterson [:cpeterson]]

Looks like this crash is a regression starting in GV 62.0a1. The crash volume is not high, so let's wait before uplifting to GV 62 Beta.

Comment 14

[Chris Peterson [:cpeterson]]

status-firefox62=wontfix because we don't need to uplift this fix to 62 Beta. The crash volume seems low. Most of the crashes are from video playback.