Closed Bug 1478806 Opened 7 years ago Closed 7 years ago

Get rid of nsIBrowserElementNextPaintListener

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

There's no particular reason for us to have this interface. The only consumer is JS-implemented, and the only caller has JS values to start with; we can just pass these as jsval.
Attachment #8995333 - Flags: review?(continuation)
Comment on attachment 8995333 [details] [diff] [review] Remove nsIBrowserElementNextPaintListener Review of attachment 8995333 [details] [diff] [review]: ----------------------------------------------------------------- Please put something like your comment 0 in the bug into the commit message.
Attachment #8995333 - Flags: review?(continuation) → review+
I forgot that passing things through xpconnect like that would double-wrap instead of unwrapping... In the new setup we need to call the function directly, not call its member. Gotta love code that catches exceptions and doesn't report them in any way.
Attachment #8995385 - Flags: review?(continuation)
Attachment #8995385 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccc5dbbd0b8 Remove nsIBrowserElementNextPaintListener. r=mccr8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1478359
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: