Closed
Bug 1478806
Opened 7 years ago
Closed 7 years ago
Get rid of nsIBrowserElementNextPaintListener
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
3.84 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
720 bytes,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
There's no particular reason for us to have this interface. The only consumer is JS-implemented, and the only caller has JS values to start with; we can just pass these as jsval.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8995333 -
Flags: review?(continuation)
Comment 2•7 years ago
|
||
Comment on attachment 8995333 [details] [diff] [review]
Remove nsIBrowserElementNextPaintListener
Review of attachment 8995333 [details] [diff] [review]:
-----------------------------------------------------------------
Please put something like your comment 0 in the bug into the commit message.
Attachment #8995333 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 3•7 years ago
|
||
I forgot that passing things through xpconnect like that would double-wrap instead of unwrapping... In the new setup we need to call the function directly, not call its member.
Gotta love code that catches exceptions and doesn't report them in any way.
Attachment #8995385 -
Flags: review?(continuation)
Updated•7 years ago
|
Attachment #8995385 -
Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ccc5dbbd0b8
Remove nsIBrowserElementNextPaintListener. r=mccr8
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•