Open Bug 1478871 Opened 6 years ago Updated 3 months ago

Don't call AnimationHelper::SetAnimations every time we sample animations

Categories

(Core :: Graphics: WebRender, enhancement, P4)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox63 --- affected

People

(Reporter: hiro, Unassigned)

References

(Blocks 1 open bug)

Details

The function should called just once we synchronize the animations with the main-thread.
Priority: -- → P3
Priority: P3 → P4
I believe this is an optimization (a nice-to-have).  Please move it back to stage-wr-trains if I've misunderstood.
Blocks: stage-wr-next
No longer blocks: stage-wr-trains
Yes, that's right.  If AnimationHelper::SampleAnimations appears in profiles (I guess it will appears in sites that have many animations), we should fix this.

Here is the place in question, we should call AnimationHelper::SetAnimations() outside SampleAnimations.

https://hg.mozilla.org/mozilla-central/file/06173200ede0/gfx/layers/AnimationHelper.cpp#l644
Severity: normal → S3
Blocks: wr-todos
You need to log in before you can comment on or make changes to this bug.