Closed Bug 1478890 Opened 4 years ago Closed 4 years ago

Get rid of CallbackObjectHolder::ToXPCOMCallback usage in webrtc code

Categories

(Core :: WebRTC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This is creating nsXPCWrappedJS around content stuff; we want to remove the ability to do that, for sanity and security reasons.
We don't want to expose nsXPCWrappedJS to the web, and this code is doing that.
Attachment #8995407 - Flags: review?(jib)
Comment on attachment 8995407 [details] [diff] [review]
Stop using ToXPCOMCallback in GetUserMedia code

Review of attachment 8995407 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm.
Attachment #8995407 - Flags: review?(jib) → review+
Comment on attachment 8995408 [details] [diff] [review]
Stop using ToXPCOMCallback in GetUserMediaDevices

Review of attachment 8995408 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Navigator.cpp
@@ +1218,5 @@
>      return;
>    }
>  
>    MediaManager* manager = MediaManager::Get();
> +  // XXXbz aOnError seems to be unused?

It is. This async method used to do more things. Today it merely returns cached results, and strictly speaking doesn't even need to be async.

I've filed bug 1478890 as a follow-up.
Attachment #8995408 - Flags: review?(jib) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcd2189cc361
Stop using ToXPCOMCallback in GetUserMedia code.  r=jib
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ecd927fd87
Stop using ToXPCOMCallback in GetUserMediaDevices.  r=jib
https://hg.mozilla.org/mozilla-central/rev/bcd2189cc361
https://hg.mozilla.org/mozilla-central/rev/48ecd927fd87
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1478359
You need to log in before you can comment on or make changes to this bug.