1478890 - Get rid of CallbackObjectHolder::ToXPCOMCallback usage in webrtc code

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

This is creating nsXPCWrappedJS around content stuff; we want to remove the ability to do that, for sanity and security reasons.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using ToXPCOMCallback in GetUserMedia code

We don't want to expose nsXPCWrappedJS to the web, and this code is doing that.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop using ToXPCOMCallback in GetUserMediaDevices

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8995407 [details] [diff] [review]
Stop using ToXPCOMCallback in GetUserMedia code

Review of attachment 8995407 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8995408 [details] [diff] [review]
Stop using ToXPCOMCallback in GetUserMediaDevices

Review of attachment 8995408 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Navigator.cpp
@@ +1218,5 @@
>      return;
>    }
>  
>    MediaManager* manager = MediaManager::Get();
> +  // XXXbz aOnError seems to be unused?

It is. This async method used to do more things. Today it merely returns cached results, and strictly speaking doesn't even need to be async.

I've filed bug 1478890 as a follow-up.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I mean bug 1479052.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcd2189cc361
Stop using ToXPCOMCallback in GetUserMedia code.  r=jib
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ecd927fd87
Stop using ToXPCOMCallback in GetUserMediaDevices.  r=jib

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bcd2189cc361
https://hg.mozilla.org/mozilla-central/rev/48ecd927fd87