Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

10 months ago
It's currently in SpiderMonkey style, and needs converting to Gecko style. I'll do this in two steps:

- Run clang-format to fix up whitespace.

- Manually do other stuff, such as fixing brace style, using mFoo/aFoo naming, etc.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Comment 3

10 months ago
froydnj: I will combine the two patches before landing in order to minimize blame churn. And apologies for the tedious reviews.

Comment 4

10 months ago
mozreview-review
Comment on attachment 8996221 [details]
Bug 1478896 - Fix HashTable.h style.

https://reviewboard.mozilla.org/r/260422/#review267534

rs=me.  I skimmed this, and nothing looks objectionable.
Attachment #8996221 - Flags: review?(nfroyd) → review+

Comment 5

10 months ago
mozreview-review
Comment on attachment 8996222 [details]
Bug 1478896 - Fix HashTable.h style.

https://reviewboard.mozilla.org/r/260424/#review267536
Attachment #8996222 - Flags: review?(nfroyd) → review+

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a8d92bdf7d0e
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.