1478896 - Fix HashTable.h style

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[Nicholas Nethercote [inactive]]

It's currently in SpiderMonkey style, and needs converting to Gecko style. I'll do this in two steps:

- Run clang-format to fix up whitespace.

- Manually do other stuff, such as fixing brace style, using mFoo/aFoo naming, etc.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1478896 - Fix HashTable.h style.

This patch was obtained by running `./mach clang-format -p mfbt/HashTable.h`.

Review commit: https://reviewboard.mozilla.org/r/260422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260422/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1478896 - Fix HashTable.h style.

This patch converts HashTable.h from SpiderMonkey style to Gecko style. Most
significantly:

- It adds braces around single-statement if/else/for/while blocks.

- It renames class members to `mFoo` form and arguments to `aFoo` form.

- It converts `typedef Old New` to `using New = Old` throughout.

Review commit: https://reviewboard.mozilla.org/r/260424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260424/

Comment 3

[Nicholas Nethercote [inactive]]

froydnj: I will combine the two patches before landing in order to minimize blame churn. And apologies for the tedious reviews.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8996221 [details]
Bug 1478896 - Fix HashTable.h style.

https://reviewboard.mozilla.org/r/260422/#review267534

rs=me.  I skimmed this, and nothing looks objectionable.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8996222 [details]
Bug 1478896 - Fix HashTable.h style.

https://reviewboard.mozilla.org/r/260424/#review267536

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d92bdf7d0e
Fix HashTable.h style. r=froydnj

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a8d92bdf7d0e