Closed
Bug 1478896
Opened 7 years ago
Closed 7 years ago
Fix HashTable.h style
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
It's currently in SpiderMonkey style, and needs converting to Gecko style. I'll do this in two steps:
- Run clang-format to fix up whitespace.
- Manually do other stuff, such as fixing brace style, using mFoo/aFoo naming, etc.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
![]() |
Assignee | |
Comment 3•7 years ago
|
||
froydnj: I will combine the two patches before landing in order to minimize blame churn. And apologies for the tedious reviews.
![]() |
||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8996221 [details]
Bug 1478896 - Fix HashTable.h style.
https://reviewboard.mozilla.org/r/260422/#review267534
rs=me. I skimmed this, and nothing looks objectionable.
Attachment #8996221 -
Flags: review?(nfroyd) → review+
![]() |
||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8996222 [details]
Bug 1478896 - Fix HashTable.h style.
https://reviewboard.mozilla.org/r/260424/#review267536
Attachment #8996222 -
Flags: review?(nfroyd) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d92bdf7d0e
Fix HashTable.h style. r=froydnj
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•