1478917 - [LTO][mac] ld crash during configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO.

While fiddling with clang (upgrading it and applying some miscompilation
patches), my mac LTO builds started to fail because ld64 would crash
during configure.

It turns out, it was crashing trying to print a warning it shouldn't
even print out, about failure to create a cache path.

This, in turn, is due to a pointer not being initialized in the ld64
code. I sent this upstream, and this was promptly fixed:
https://github.com/tpoechtrager/cctools-port/pull/57

However, since our last update of cctools-port, upstream landed a change
that broke support for tbd files if you don't compile against the new
libtapi library. Doing so is more work than I'm ready to put here,
so we just cherry-pick the fix.

Review commit: https://reviewboard.mozilla.org/r/259870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259870/

Comment 2

[(Away)]

Comment on attachment 8995424 [details]
Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO.

https://reviewboard.mozilla.org/r/259870/#review266970

Should build-cctools-port-macosx.sh get this too?

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8995424 [details]
Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO.

https://reviewboard.mozilla.org/r/259870/#review266968

Comment 4

[Mike Hommey [:glandium]]

(In reply to David Major [:dmajor] from comment #2)
> Comment on attachment 8995424 [details]
> Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO.
> 
> https://reviewboard.mozilla.org/r/259870/#review266970
> 
> Should build-cctools-port-macosx.sh get this too?

Ah, yes. Forgot to update it.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8995424 [details]
Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259870/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91307a0650ac
Apply upstream patch fixing ld64 crash with LTO. r=dmajor,froydnj

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/91307a0650ac