1478969 - RUSTFLAGS set in mozconfig should not be applied when building host libraries and programs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8995503 [details] [diff] [review]
Patch

I'm going to punt this one to Nathan.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8995503 [details] [diff] [review]
Patch

Review of attachment 8995503 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93e52a1e5d88
Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj

Comment 5

[Andreea Pavel [:apavel]]

Backed out for linux tier2 rust build bustages 

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=93e52a1e5d88d169fca83b1f8e9f0eb78d809cc9
 
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195122207&repo=mozilla-inbound&lineNumber=40381

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/1860f2aa532d6312145e198f095018dcf3bebae2

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08d82015e170
Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/08d82015e170

Comment 8

[Marco Castelluccio [:marco]]

I had forgotten to update another usage of RUN_CARGO, it's working now.