Closed Bug 1478990 Opened 4 years ago Closed 4 years ago

Make NonCustomPropertyId <-> nsCSSPropertyId conversions fast.

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Make NonCustomPropertyId <-> nsCSSPropertyId conversions fast.
46 bytes, text/x-phabricator-request
xidorn
: review+
Details | Review 
It appears in the profile of bug 1478953. Very low hanging fruit, but also easy.
We have a different order in nsCSSPropertyId for no good reason. The only
invariant there is that longhands come before shorthands, and shorthands before
aliases.

Luckily that's also an invariant that NonCustomPropertyId has, so we can reuse
them.
Comment on attachment 8995514 [details]
Make NonCustomPropertyId <-> nsCSSPropertyId conversions fast.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

https://phabricator.services.mozilla.com/D2463
Attachment #8995514 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d7bf663d77
Make NonCustomPropertyId <-> nsCSSPropertyId conversions fast. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/a8d7bf663d77
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1479681
Depends on: 1479686
You need to log in before you can comment on or make changes to this bug.