1479027 - Test case from bug 1476600 hits assertion in MSG

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Byron Campen [:bwc]]

Assertion failure: inputStream, at /Users/bcampen/checkouts/mozilla-central/dom/media/MediaStreamGraph.cpp:2330

It looks like there's some corner case the test is hitting, but not sure what exactly. The test case does a lot of removeTrack/addTrack with the same track, perhaps that is the salient feature.

Comment 1

[Paul Adenot (:padenot)]

Someone is doing something weird with streams.

Comment 2

[Andreas Pehrson [:pehrsons]]

I can repro. Will dig more tomorrow.

Comment 3

[Andreas Pehrson [:pehrsons]]

So this happens when we are looking for the input stream and track for a track that has already ended (so the input is gone). This is a legit case that we should handle. I'll make AddListenerImpl ignore announcing the track in this corner case.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Don't announce existing ended tracks when they have no input

Comment 5

[Phabricator Automation]

Comment on attachment 8996657 [details]
Don't announce existing ended tracks when they have no input

Paul Adenot (:padenot) has approved the revision.

https://phabricator.services.mozilla.com/D2596

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d35c92fddce
Don't announce existing ended tracks when they have no input r=padenot

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2d35c92fddce