Closed Bug 1479027 Opened 6 years ago Closed 6 years ago

Test case from bug 1476600 hits assertion in MSG

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

60 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bwc, Assigned: pehrsons)

References

Details

Attachments

(1 file)

Assertion failure: inputStream, at /Users/bcampen/checkouts/mozilla-central/dom/media/MediaStreamGraph.cpp:2330

It looks like there's some corner case the test is hitting, but not sure what exactly. The test case does a lot of removeTrack/addTrack with the same track, perhaps that is the salient feature.
Someone is doing something weird with streams.
Flags: needinfo?(apehrson)
Rank: 25
Priority: -- → P3
I can repro. Will dig more tomorrow.
Assignee: nobody → apehrson
Status: NEW → ASSIGNED
Flags: needinfo?(apehrson)
So this happens when we are looking for the input stream and track for a track that has already ended (so the input is gone). This is a legit case that we should handle. I'll make AddListenerImpl ignore announcing the track in this corner case.
Comment on attachment 8996657 [details]
Don't announce existing ended tracks when they have no input

Paul Adenot (:padenot) has approved the revision.

https://phabricator.services.mozilla.com/D2596
Attachment #8996657 - Flags: review+
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d35c92fddce
Don't announce existing ended tracks when they have no input r=padenot
https://hg.mozilla.org/mozilla-central/rev/2d35c92fddce
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: