Remove more unused/unnecessary methods from nsIAnnotationService & Observer methods

RESOLVED FIXED in Firefox 63

Status

()

P1
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
After bug 1468980 lands, we can remove nsIAnnotationObserver::onPageAnnotationSet/Removed as we no longer need those notifications.

Additionally, there's a few methods in nsIAnnotationService that are unused, plus we can remove all the noscript get{Page,Item}Annotation* methods, and remove the set equivalents from the idl.

Although there's a little work to keep set moving, I think this makes the service a lot smaller and a lot easier to know what we need to do to remove it completely.
(Assignee)

Comment 1

5 months ago
Created attachment 8995585 [details]
Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed.

MozReview-Commit-ID: JkUhtuV1fvU
(Assignee)

Comment 2

5 months ago
Created attachment 8995587 [details]
Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService.

MozReview-Commit-ID: I9qq71RLXYH

Depends on D2473
(Assignee)

Updated

5 months ago
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [fxsearch]
Comment on attachment 8995585 [details]
Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2473
Attachment #8995585 - Flags: review+
Comment on attachment 8995587 [details]
Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2474
Attachment #8995587 - Flags: review+

Comment 5

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b3eff02c54f
Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. r=mak

Comment 6

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa62bab6783
Remove unused/unnecessary methods from nsIAnnotationService. r=mak
(Assignee)

Updated

4 months ago
Blocks: 1479764

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b3eff02c54f
https://hg.mozilla.org/mozilla-central/rev/7aa62bab6783
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.