Closed
Bug 1479053
Opened 6 years ago
Closed 6 years ago
Remove more unused/unnecessary methods from nsIAnnotationService & Observer methods
Categories
(Toolkit :: Places, enhancement, P1)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
After bug 1468980 lands, we can remove nsIAnnotationObserver::onPageAnnotationSet/Removed as we no longer need those notifications. Additionally, there's a few methods in nsIAnnotationService that are unused, plus we can remove all the noscript get{Page,Item}Annotation* methods, and remove the set equivalents from the idl. Although there's a little work to keep set moving, I think this makes the service a lot smaller and a lot easier to know what we need to do to remove it completely.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: JkUhtuV1fvU
|
|
Assignee | |
Comment 2•6 years ago
|
||
MozReview-Commit-ID: I9qq71RLXYH Depends on D2473
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [fxsearch]
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8995585 [details] Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. Marco Bonardo [::mak] has approved the revision. https://phabricator.services.mozilla.com/D2473
Attachment #8995585 -
Flags: review+
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8995587 [details] Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService. Marco Bonardo [::mak] has approved the revision. https://phabricator.services.mozilla.com/D2474
Attachment #8995587 -
Flags: review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b3eff02c54f Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. r=mak
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7aa62bab6783 Remove unused/unnecessary methods from nsIAnnotationService. r=mak
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1b3eff02c54f https://hg.mozilla.org/mozilla-central/rev/7aa62bab6783
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•