1479053 - Remove more unused/unnecessary methods from nsIAnnotationService & Observer methods

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Mark Banner (:standard8)]

After bug 1468980 lands, we can remove nsIAnnotationObserver::onPageAnnotationSet/Removed as we no longer need those notifications.

Additionally, there's a few methods in nsIAnnotationService that are unused, plus we can remove all the noscript get{Page,Item}Annotation* methods, and remove the set equivalents from the idl.

Although there's a little work to keep set moving, I think this makes the service a lot smaller and a lot easier to know what we need to do to remove it completely.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed.

MozReview-Commit-ID: JkUhtuV1fvU

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService.

MozReview-Commit-ID: I9qq71RLXYH

Depends on D2473

Comment 3

[Phabricator Automation]

Comment on attachment 8995585 [details]
Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2473

Comment 4

[Phabricator Automation]

Comment on attachment 8995587 [details]
Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2474

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b3eff02c54f
Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. r=mak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa62bab6783
Remove unused/unnecessary methods from nsIAnnotationService. r=mak

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1b3eff02c54f
https://hg.mozilla.org/mozilla-central/rev/7aa62bab6783