Open Bug 1479067 Opened 6 years ago Updated 2 years ago

Keyboard Navigation does not toggle Italics with Enter key (but toggles with Space Bar)

Categories

(DevTools :: Inspector, defect, P3)

63 Branch
All
Unspecified
defect

Tracking

(Not tracked)

People

(Reporter: u554753, Unassigned)

References

(Blocks 1 open bug)

Details

Background:
Set the following values to true:
devtools.chrome.enabled = true
devtools.inspector.fonteditor.enabled = true

Steps to Reproduce:
1. Navigate to https://v-fonts.com
2. Navigate to "Renner" font and click the link for "Info/fonts"
3. Navigate to "Developer Toolbar" CTRL+SHIFT+I
4. Using the tab key, navigate to the "Fonts" sub-section in the right window of the inspector.
5. Using the keyboard, change the values on the "Size" "Weight" and "Italic" fields.

Expected Results:
The italics field can be changed using the Enter/Return key and the Space Bar.

Actual Results:
The italics field can only be changed using the Space Bar.
Summary: Keyboard Navigation does does not toggle Italics with Enter key (but toggles with Space Bar) → Keyboard Navigation does not toggle Italics with Enter key (but toggles with Space Bar)
Technically, it shouldn't work with the Enter key. The "Italic" toggle is a styled HTML checkbox input. The spacebar toggles the checked state which changes the toggle rendering. Pressing Enter on a focused checkbox does not change its state.

In a form context, pressing Enter wouldn't be desirable because that would submit the form the checkbox belongs to. 

But since the Font Editor controls are not part of a form and because there is precedent with similar toggles reacting to Enter (ex: Enable Tracking Protection), we should probably be consistent and implement this behavior.
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee: rcaliman → nobody
Status: ASSIGNED → NEW
Blocks: 1280059
No longer blocks: 1441576
Component: Inspector: Fonts → Inspector
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.