Closed
Bug 1479129
Opened 6 years ago
Closed 6 years ago
Implement support for updateProperties.highlighted in browser.tabs.update()
Categories
(WebExtensions :: General, enhancement, P5)
WebExtensions
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
browser.tabs.update() should be able to change whether a tab is highlighted. Currently it's not supported. https://searchfox.org/mozilla-central/rev/704612cf4426f0f0510b3e160895578c319a3270/browser/components/extensions/schemas/tabs.json#834-835
Updated•6 years ago
|
Priority: -- → P5
Updated•6 years ago
|
Severity: normal → enhancement
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 9002318 [details] Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy Not sure why phabricator created a different patch
Attachment #9002318 -
Attachment is obsolete: true
Comment 4•6 years ago
|
||
Comment on attachment 9002489 [details] Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,jaws Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9002489 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
:jaws is away. Do I need another reviewer for the tabbrowser changes or does your approval suffice?
Flags: needinfo?(mixedpuppy)
Comment 6•6 years ago
|
||
I think someone should, ask Gijs if he can review.
Flags: needinfo?(mixedpuppy) → needinfo?(gijskruitbosch+bugs)
Updated•6 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Comment 7•6 years ago
|
||
Comment on attachment 9002489 [details] Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,jaws :Gijs (he/him) has approved the revision.
Attachment #9002489 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/073b8e49194a Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,Gijs
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/073b8e49194a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Comment 10•6 years ago
|
||
Can you please some STRs to this issue(and a test webextension if possible) or mark it as "qe-verify-" ?
Updated•6 years ago
|
Flags: needinfo?(oriol-bugzilla)
Assignee | ||
Comment 11•6 years ago
|
||
Covered by automated tests
Flags: needinfo?(oriol-bugzilla) → qe-verify-
Comment 12•6 years ago
|
||
Updated the browser compatibility data for highlighted and added this to the release notes: tabs.update supports changing the selection status of a tab by including highlighted: true in the updateProperties parameter (bug 1479129).
Flags: needinfo?(oriol-bugzilla)
Keywords: dev-doc-needed → dev-doc-complete
Comment 14•6 years ago
|
||
One thing I didn't ask is whether the support for Firefox on Android is the same. If not, should it be supported but with a note or not supported?
Flags: needinfo?(oriol-bugzilla)
QA Contact: ddurst
Assignee | ||
Comment 15•6 years ago
|
||
Android does not support multi-tab selections, so updateProperties.highlighted can't work there. It's not supported. https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/mobile/android/components/extensions/schemas/tabs.json#648
Flags: needinfo?(oriol-bugzilla)
Updated•6 years ago
|
QA Contact: ddurst
You need to log in
before you can comment on or make changes to this bug.
Description
•