Implement support for updateProperties.highlighted in browser.tabs.update()

RESOLVED FIXED in Firefox 63

Status

enhancement
P5
normal
RESOLVED FIXED
9 months ago
5 months ago

People

(Reporter: Oriol, Assigned: Oriol)

Tracking

({dev-doc-complete})

unspecified
mozilla63
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 months ago
browser.tabs.update() should be able to change whether a tab is highlighted.

Currently it's not supported.

https://searchfox.org/mozilla-central/rev/704612cf4426f0f0510b3e160895578c319a3270/browser/components/extensions/schemas/tabs.json#834-835

Updated

9 months ago
Priority: -- → P5

Updated

9 months ago
Severity: normal → enhancement
(Assignee)

Updated

8 months ago
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 3

8 months ago
Comment on attachment 9002318 [details]
Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy

Not sure why phabricator created a different patch
Attachment #9002318 - Attachment is obsolete: true
Comment on attachment 9002489 [details]
Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,jaws

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #9002489 - Flags: review+
(Assignee)

Comment 5

8 months ago
:jaws is away. Do I need another reviewer for the tabbrowser changes or does your approval suffice?
Flags: needinfo?(mixedpuppy)
I think someone should, ask Gijs if he can review.
Flags: needinfo?(mixedpuppy) → needinfo?(gijskruitbosch+bugs)

Updated

8 months ago
Flags: needinfo?(gijskruitbosch+bugs)

Comment 7

8 months ago
Comment on attachment 9002489 [details]
Bug 1479129 - Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,jaws

:Gijs (he/him) has approved the revision.
Attachment #9002489 - Flags: review+
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 8

8 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/073b8e49194a
Implement support for updateProperties.highlighted in browser.tabs.update(). r=mixedpuppy,Gijs
Keywords: checkin-needed

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/073b8e49194a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(Assignee)

Updated

8 months ago
Keywords: dev-doc-needed

Comment 10

8 months ago
Can you please some STRs to this issue(and a test webextension if possible) or mark it as "qe-verify-" ?

Updated

8 months ago
Flags: needinfo?(oriol-bugzilla)
(Assignee)

Comment 11

8 months ago
Covered by automated tests
Flags: needinfo?(oriol-bugzilla) → qe-verify-

Comment 12

8 months ago
Updated the browser compatibility data for highlighted and added this to the release notes:

tabs.update supports changing the selection status of a tab by including highlighted: true in the updateProperties parameter (bug 1479129).
Flags: needinfo?(oriol-bugzilla)
(Assignee)

Comment 13

8 months ago
That's good
Flags: needinfo?(oriol-bugzilla)

Comment 14

7 months ago
One thing I didn't ask is whether the support for Firefox on Android is the same. If not, should it be supported but with a note or not supported?
Flags: needinfo?(oriol-bugzilla)
QA Contact: ddurst
(Assignee)

Comment 15

7 months ago
Android does not support multi-tab selections, so updateProperties.highlighted can't work there. It's not supported.
https://searchfox.org/mozilla-central/rev/924e3d96d81a40d2f0eec1db5f74fc6594337128/mobile/android/components/extensions/schemas/tabs.json#648
Flags: needinfo?(oriol-bugzilla)
QA Contact: ddurst
You need to log in before you can comment on or make changes to this bug.