1479130 - Dispatch an event when multiselection changes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Oriol Brufau [:Oriol]]

This is necessary for bug 1474440.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1479130 - Dispatch TabMultiSelect event when multiselection changes

Review commit: https://reviewboard.mozilla.org/r/260088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260088/

Comment 2

[Oriol Brufau [:Oriol]]

There is already the TabSelect event, so I called this one TabMultiSelect. Other suggestions are welcome.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995702 [details]
Bug 1479130 - Dispatch TabMultiSelect event when multiselection changes

https://reviewboard.mozilla.org/r/260088/#review267168

::: browser/base/content/tabbrowser.js:156
(Diff revision 1)
> +  _multiSelectChangeAdditions: new Set(),
> +
> +  _multiSelectChangeRemovals: new Set(),

Please use a WeakSet for these.

Comment 4

[Oriol Brufau [:Oriol]]

I need to check the size and that's more difficult for weaksets. I clear the sets at the next tick so weaksets don't seem worth

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995702 [details]
Bug 1479130 - Dispatch TabMultiSelect event when multiselection changes

https://reviewboard.mozilla.org/r/260088/#review267558

Okay, I'm fine with it as-is, I just wanted a WeakSet to be on the safer side. It is possible to get the length of a WeakSet but it's more work.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Oriol, are you waiting on something else or is this ready to land?

Comment 7

[Oriol Brufau [:Oriol]]

I can't add checkin-needed from my phone and I'm away from my PC. You can land it

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s bc324ccca4aaee50f137e6adb4ff41109a082c2c -d 8236a828c129: rebasing 476659:bc324ccca4aa "Bug 1479130 - Dispatch TabMultiSelect event when multiselection changes r=jaws" (tip)
merging browser/base/content/tabbrowser.js
merging browser/base/content/tabbrowser.xml
merging browser/base/content/test/tabs/browser.ini
warning: conflicts while merging browser/base/content/tabbrowser.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ecde963891e
Dispatch TabMultiSelect event when multiselection changes

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ecde963891e