1479133 - Enable test for bug 1478643 on WebRender

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P3)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

We have to call WebRenderLayerManager::AddCompositorAnimationsIdForDiscard somewhere for the case in bug 1478643.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Do'h idiot!  I've been noticing that we have to need to fix RestyleManager::AddLayerChangesForAnimation for WebRender, but haven't filed yet.  And I did totally forget about it. :/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6751a1c8faffed6e6b4d96eef347c1ba06c88010

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender.

WebRender has no layers at all.

Review commit: https://reviewboard.mozilla.org/r/260182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260182/

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8995838 [details]
Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender.

https://reviewboard.mozilla.org/r/260182/#review267180

::: layout/base/RestyleManager.cpp:1797
(Diff revision 1)
> -    // for the property but have no layer.
> +    // for the property but have no layer or corresponding animation info on
> +    // the WebRender.

...but have no layer or, for the case of WebRender, no corresponding animation info.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8995838 [details]
Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260182/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0626f30fbcd3
Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r=birtles

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0626f30fbcd3