Closed Bug 1479234 Opened Last year Closed Last year

Make the ipc calls for getting animation values on the compositor more generic

Categories

(Core :: DOM: Animation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(5 files)

I think Boris is interested in this. I am going to ask him to review. :)
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> I think Boris is interested in this. I am going to ask him to review. :)

Haha, ya. I am trying to catch up on my lost half year~
(In reply to Boris Chiou [:boris] from comment #6)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> > I think Boris is interested in this. I am going to ask him to review. :)
> 
> Haha, ya. I am trying to catch up on my lost half year~

Nice!  That's good to know.  I will send one more review request. :)
Comment on attachment 8995766 [details]
Bug 1479234 - Introduce a generic function to get an animation value on the compositor.

https://reviewboard.mozilla.org/r/260136/#review267358

This idea looks good to me. Thanks. :)

::: dom/base/nsDOMWindowUtils.cpp:3725
(Diff revision 1)
> -      if (transform.type() == MaybeTransform::TMatrix4x4) {
> -        Matrix4x4 matrix = transform.get_Matrix4x4();
> -        cssValue = nsComputedDOMStyle::MatrixToCSSValue(matrix);
> +      if (value.type() == OMTAValue::TMatrix4x4) {
> +        MOZ_ASSERT(value.type() == OMTAValue::TMatrix4x4);
> +        cssValue = nsComputedDOMStyle::MatrixToCSSValue(value.get_Matrix4x4());

nit: This assertion is redundent becasue the `if` check will filter out the false case.
Attachment #8995766 - Flags: review?(boris.chiou) → review+
Comment on attachment 8995767 [details]
Bug 1479234 - Drop GetAnimationOpacity and GetAnimationTransform ipc calls.

https://reviewboard.mozilla.org/r/260138/#review267366
Attachment #8995767 - Flags: review?(boris.chiou) → review+
Comment on attachment 8995769 [details]
Bug 1479234 - Factor out a function getting an OMTAValue from the compositor.

https://reviewboard.mozilla.org/r/260142/#review267368

::: dom/base/nsDOMWindowUtils.cpp:3678
(Diff revision 1)
> +          animationData->GetAnimationInfo().GetCompositorAnimationsId(),
> +          &value);

nit: It seems the idention is 2 whitespaces in this function, so let's also use 2 whitespaces here. :)
Attachment #8995769 - Flags: review?(boris.chiou) → review+
Comment on attachment 8995766 [details]
Bug 1479234 - Introduce a generic function to get an animation value on the compositor.

This patch adds new two synchronous ipc calls for test purpose, and the next patch will drop four synchronous ipc calls.
Attachment #8995766 - Flags: review?(nfroyd)
Attachment #8995767 - Flags: review?(nfroyd)
Comment on attachment 8995767 [details]
Bug 1479234 - Drop GetAnimationOpacity and GetAnimationTransform ipc calls.

https://reviewboard.mozilla.org/r/260138/#review267410

r=me for the sync-messages.ini changes.
Attachment #8995767 - Flags: review?(nfroyd) → review+
Comment on attachment 8995766 [details]
Bug 1479234 - Introduce a generic function to get an animation value on the compositor.

https://reviewboard.mozilla.org/r/260136/#review267408

r=me for the sync-messages.ini changes.
Attachment #8995766 - Flags: review?(nfroyd) → review+
Thank you all for reviewing!
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ffc8e9d5686
Introduce a generic function to get an animation value on the compositor. r=boris,froydnj
https://hg.mozilla.org/integration/autoland/rev/c8c2625a33ba
Drop GetAnimationOpacity and GetAnimationTransform ipc calls. r=boris,froydnj
https://hg.mozilla.org/integration/autoland/rev/c3bab1bc97cf
Fix the header for gfx::Glyph. r=kats
https://hg.mozilla.org/integration/autoland/rev/6ecc1666f571
Factor out a function getting an OMTAValue from the compositor. r=boris
Backed out 4 changesets (bug 1479234) for build bustage at build/src/gfx/vr/ipc/VRLayerChild.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/775c7c08f6fd3cb3e9d53a889f7860654cf60c9a

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6ecc1666f571b6c97b7c30e2795a91334d09d65f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190973410&repo=autoland&lineNumber=18344

[task 2018-07-30T21:24:22.354Z] 21:24:22     INFO -  dom/base/test/gtest
[task 2018-07-30T21:24:22.354Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest'
[task 2018-07-30T21:24:22.354Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest'
[task 2018-07-30T21:24:22.354Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest'
[task 2018-07-30T21:24:22.720Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.723Z] 21:24:22     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o GrAAStrokeRectOp.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DSKIA_IMPLEMENTATION=1 -DSK_PDF_USE_SFNTLY=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/obj-firefox/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/c -I/builds/worker/workspace/build/src/gfx/skia/skia/include/codec -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/include/encode -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/pathops -I/builds/worker/workspace/build/src/gfx/skia/skia/include/ports -I/builds/worker/workspace/build/src/gfx/skia/skia/include/private -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/include/views -I/builds/worker/workspace/build/src/gfx/skia/skia/src/core -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/gl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/glsl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/image -I/builds/worker/workspace/build/src/gfx/skia/skia/src/lazy -I/builds/worker/workspace/build/src/gfx/skia/skia/src/opts -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sfnt -I/builds/worker/workspace/build/src/gfx/skia/skia/src/shaders -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sksl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/win -I/builds/worker/workspace/build/src/gfx/sfntly/cpp/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Wno-deprecated-declarations -Wno-overloaded-virtual -Wno-shadow -Wno-sign-compare -Wno-unreachable-code -Wno-unused-function -Wno-implicit-fallthrough -Wno-inconsistent-missing-override -Wno-macro-redefined -Wno-unused-private-field  -MD -MP -MF .deps/GrAAStrokeRectOp.o.pp   /builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/ops/GrAAStrokeRectOp.cpp
[task 2018-07-30T21:24:22.725Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.725Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.725Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.725Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.726Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.985Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest'
[task 2018-07-30T21:24:22.987Z] 21:24:22     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_dom_base_test_gtest0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/base/test/gtest -I/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/Unified_cpp_dom_base_test_gtest0.o.pp   /builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest/Unified_cpp_dom_base_test_gtest0.cpp
[task 2018-07-30T21:24:22.987Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base/test/gtest'
[task 2018-07-30T21:24:22.988Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.988Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.988Z] 21:24:22     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:22.990Z] 21:24:22     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.147Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.149Z] 21:24:23     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o GrMSAAPathRenderer.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DSKIA_IMPLEMENTATION=1 -DSK_PDF_USE_SFNTLY=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/obj-firefox/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/c -I/builds/worker/workspace/build/src/gfx/skia/skia/include/codec -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/include/encode -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/pathops -I/builds/worker/workspace/build/src/gfx/skia/skia/include/ports -I/builds/worker/workspace/build/src/gfx/skia/skia/include/private -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/include/views -I/builds/worker/workspace/build/src/gfx/skia/skia/src/core -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/effects -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/gl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/glsl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/image -I/builds/worker/workspace/build/src/gfx/skia/skia/src/lazy -I/builds/worker/workspace/build/src/gfx/skia/skia/src/opts -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sfnt -I/builds/worker/workspace/build/src/gfx/skia/skia/src/shaders -I/builds/worker/workspace/build/src/gfx/skia/skia/src/sksl -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/mac -I/builds/worker/workspace/build/src/gfx/skia/skia/src/utils/win -I/builds/worker/workspace/build/src/gfx/sfntly/cpp/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Wno-deprecated-declarations -Wno-overloaded-virtual -Wno-shadow -Wno-sign-compare -Wno-unreachable-code -Wno-unused-function -Wno-implicit-fallthrough -Wno-inconsistent-missing-override -Wno-macro-redefined -Wno-unused-private-field  -MD -MP -MF .deps/GrMSAAPathRenderer.o.pp   /builds/worker/workspace/build/src/gfx/skia/skia/src/gpu/ops/GrMSAAPathRenderer.cpp
[task 2018-07-30T21:24:23.149Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.150Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.150Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.151Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.152Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.392Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr'
[task 2018-07-30T21:24:23.393Z] 21:24:23     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -target x86_64-apple-darwin11 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -o Unified_cpp_gfx_vr0.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/vr -I/builds/worker/workspace/build/src/obj-firefox/gfx/vr -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/gfx/layers/d3d11 -I/builds/worker/workspace/build/src/gfx/thebes -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo  -MD -MP -MF .deps/Unified_cpp_gfx_vr0.o.pp   /builds/worker/workspace/build/src/obj-firefox/gfx/vr/Unified_cpp_gfx_vr0.cpp
[task 2018-07-30T21:24:23.393Z] 21:24:23     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/gfx/vr/Unified_cpp_gfx_vr0.cpp:56:
[task 2018-07-30T21:24:23.393Z] 21:24:23     INFO -  /builds/worker/workspace/build/src/gfx/vr/ipc/VRLayerChild.cpp:74:8: error: use of undeclared identifier 'gfxPlatform'
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -    if (!gfxPlatform::GetPlatform()->DidRenderingDeviceReset()) {
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -         ^
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -  1 error generated.
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1052: recipe for target 'Unified_cpp_gfx_vr0.o' failed
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -  make[4]: *** [Unified_cpp_gfx_vr0.o] Error 1
[task 2018-07-30T21:24:23.394Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr'
[task 2018-07-30T21:24:23.395Z] 21:24:23     INFO -  /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'gfx/vr/target' failed
[task 2018-07-30T21:24:23.395Z] 21:24:23     INFO -  make[3]: *** [gfx/vr/target] Error 2
[task 2018-07-30T21:24:23.396Z] 21:24:23     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2018-07-30T21:24:23.396Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.397Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.398Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.398Z] 21:24:23     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
[task 2018-07-30T21:24:23.434Z] 21:24:23     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/skia'
Flags: needinfo?(hikezoe)
The error on Mac is just a missing header inclusion.  It's not a big deal.

The error on Windows is annoying.

The error is;
 22:34:54     INFO -  z:/build/build/src/dom/base/nsGlobalWindowInner.cpp(7925,2):  error: "Never include windows.h in this file!"
 22:34:54     INFO -  #error "Never include windows.h in this file!"
 22:34:54     INFO -   ^

Apparently including 'LayersMessage.h' in nsDOMWindows.h caused this error.  I am going to make GetOMTAValue as a static function, it would be a bit awkward though (the function has to take WebRenderBridgeChild* from the call sites).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=804a73b703b283238fda2912c63d661d5f68714f
Flags: needinfo?(hikezoe)
Boris, does the workaround in comment 22 sound reasonable?  If so, I will land them once the try looks green.
Flags: needinfo?(boris.chiou)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #22)
> The error on Mac is just a missing header inclusion.  It's not a big deal.
> 
> The error on Windows is annoying.
> 
> The error is;
>  22:34:54     INFO - 
> z:/build/build/src/dom/base/nsGlobalWindowInner.cpp(7925,2):  error: "Never
> include windows.h in this file!"
>  22:34:54     INFO -  #error "Never include windows.h in this file!"
>  22:34:54     INFO -   ^
> 
> Apparently including 'LayersMessage.h' in nsDOMWindows.h caused this error. 
> I am going to make GetOMTAValue as a static function, it would be a bit
> awkward though (the function has to take WebRenderBridgeChild* from the call
> sites).
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=804a73b703b283238fda2912c63d661d5f68714f

It's ok to me. We just want to factor out the common code. Let make it static.
Flags: needinfo?(boris.chiou)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #23)
> Boris, does the workaround in comment 22 sound reasonable?  If so, I will
> land them once the try looks green.
(In reply to Boris Chiou [:boris] from comment #24)
> It's ok to me. We just want to factor out the common code. Let make it
> static.

Or using a closure is also ok to me.
(In reply to Boris Chiou [:boris] from comment #25)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #23)
> > Boris, does the workaround in comment 22 sound reasonable?  If so, I will
> > land them once the try looks green.
> (In reply to Boris Chiou [:boris] from comment #24)
> > It's ok to me. We just want to factor out the common code. Let make it
> > static.
> 
> Or using a closure is also ok to me.

Oh sounds nice.  Why I hadn't notice it at all? :)  That's said, I will let the patches go as they are in the try, and file a new bug for using closures there.
Thanks!
(In reply to Hiroyuki Ikezoe (:hiro) from comment #26)
> (In reply to Boris Chiou [:boris] from comment #25)
> > Or using a closure is also ok to me.
> 
> Oh sounds nice.  Why I hadn't notice it at all? :)  That's said, I will let
> the patches go as they are in the try, and file a new bug for using closures
> there.
> Thanks!

Cool. Sounds good. :)
Comment on attachment 8996160 [details]
Bug 1479234 - Include missing headers in D3D11YCbCrImage.cpp and VRLayerChild.cpp.

https://reviewboard.mozilla.org/r/260394/#review267454
Attachment #8996160 - Flags: review?(hikezoe) → review+
Depends on: 1479636
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f23bfde75fc5
Introduce a generic function to get an animation value on the compositor. r=boris,froydnj
https://hg.mozilla.org/integration/autoland/rev/ebf046454098
Drop GetAnimationOpacity and GetAnimationTransform ipc calls. r=boris,froydnj
https://hg.mozilla.org/integration/autoland/rev/23119363c98a
Fix the header for gfx::Glyph. r=kats
https://hg.mozilla.org/integration/autoland/rev/7356e631ab34
Factor out a function getting an OMTAValue from the compositor. r=boris
https://hg.mozilla.org/integration/autoland/rev/34b671e3dd5d
Include missing headers in D3D11YCbCrImage.cpp and VRLayerChild.cpp. r=hiro
You need to log in before you can comment on or make changes to this bug.