Closed Bug 1479235 Opened 6 years ago Closed 6 years ago

Stop whitelisting SpecialPowers modules for content process startup

Categories

(Core :: DOM: Content Processes, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

SpecialPowers eagerly loads a bunch of helper modules at content process startup. Those helper modules also pull in some other modules that we don't want loaded in the content process, particularly NetUtil.jsm and FileUtils.jsm. Lazily loading the helper modules also allows us to remove those modules from the whitelist.
Comment on attachment 8995760 [details]
Bug 1479235: Stop whitelisting SpecialPowers helper modules for content process startup.

https://reviewboard.mozilla.org/r/260120/#review267332
Attachment #8995760 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f9c9580f68754c4617c7a8e674cf99cf917caac
Bug 1479235: Stop whitelisting SpecialPowers helper modules for content process startup. r=felipe
https://hg.mozilla.org/mozilla-central/rev/8f9c9580f687
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856
Status: RESOLVED → REOPENED
Flags: needinfo?(kmaglione+bmo)
Resolution: FIXED → ---
Target Milestone: mozilla63 → ---
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/ed17d58978fd
Stop whitelisting SpecialPowers helper modules for content process startup: Remove unused FileUtils import. a=eslint-fix
https://hg.mozilla.org/integration/mozilla-inbound/rev/56dc94316408a37796340168f457b0cb42e96a00
Bug 1479235: Stop whitelisting SpecialPowers helper modules for content process startup. r=felipe
https://hg.mozilla.org/mozilla-central/rev/56dc94316408
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: