Closed Bug 1479318 Opened Last year Closed Last year

Minimize the amount of content Findbar code loaded by default.

Categories

(Toolkit :: Find Toolbar, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [overhead:10k])

Attachments

(1 file)

We load a fairly large amount of findbar code into every content frameloader, even when no search has happened in it. The key handling logic for starting fast find is a bit hairy, and annoyingly complicated, but a lot of the rest of the code can be loaded lazily.
Comment on attachment 8995841 [details]
Bug 1479318: Minimize the amount of content Findbar code loaded by default.

https://reviewboard.mozilla.org/r/260186/#review267578
Attachment #8995841 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/177e4adb94d1b63002577995deed230ba15624f8
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe
Flags: needinfo?(kmaglione+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/915862a355e959c92c9ea7fb1cd7adbcf03bfb98
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe
https://hg.mozilla.org/mozilla-central/rev/915862a355e9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856
Status: RESOLVED → REOPENED
Flags: needinfo?(kmaglione+bmo)
Resolution: FIXED → ---
Target Milestone: mozilla63 → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fffcbc03aa2dc58de08c569aa7553a5d87ce1f1
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe
https://hg.mozilla.org/mozilla-central/rev/4fffcbc03aa2
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.