1479318 - Minimize the amount of content Findbar code loaded by default.

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement)

Description

[Kris Maglione [:kmag]]

We load a fairly large amount of findbar code into every content frameloader, even when no search has happened in it. The key handling logic for starting fast find is a bit hairy, and annoyingly complicated, but a lot of the rest of the code can be loaded lazily.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1479318: Minimize the amount of content Findbar code loaded by default.

Review commit: https://reviewboard.mozilla.org/r/260186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260186/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8995841 [details]
Bug 1479318: Minimize the amount of content Findbar code loaded by default.

https://reviewboard.mozilla.org/r/260186/#review267578

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/177e4adb94d1b63002577995deed230ba15624f8
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing android om different files

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2a5aa9de1fd9760a9245ecae815a6e02bb9eef42

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191462606&repo=mozilla-inbound&lineNumber=1511

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/424f4541472c8942c7c85053c7d7eb224548e24a

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/915862a355e959c92c9ea7fb1cd7adbcf03bfb98
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/915862a355e9

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fffcbc03aa2dc58de08c569aa7553a5d87ce1f1
Bug 1479318: Minimize the amount of content Findbar code loaded by default. r=felipe

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4fffcbc03aa2