1479320 - Lazily load calendar unifinder tree

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Follow up from bug 1477958 comment 6.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1479320-lazy-unifinder-1.diff

Does the job.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9071175 [details] [diff] [review]
1479320-lazy-unifinder-1.diff

Review of attachment 9071175 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/calendar-unifinder.js
@@ +218,5 @@
> +        sortDirection = "ascending";
> +    }
> +    let tree = document.getElementById("unifinder-search-results-tree");
> +    let treecols = tree.getElementsByTagName("treecol");
> +    for (let i = 0; i < treecols.length; i++) {

Can you change this to a for..of while we are here?

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1479320-lazy-unifinder-2.diff

Comment 4

[Geoff Lankow (:darktrojan)]

I think this can live on just Daily for now, then join a later beta if it all works fine and actually helps start-up performance.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e10b0b8aa3f
Lazily load calendar unifinder tree. r=philipp

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

[if] actually helps start-up performance.

Were you able to measure improvement?

Comment 7

[Geoff Lankow (:darktrojan)]

There's many reasons we call this function, so it's difficult to say it's better in all cases. But in an extreme case, such as importing many events into a calendar which already has a lot, there's a significant improvement.