Closed
Bug 1479366
Opened 7 years ago
Closed 7 years ago
JsTerm cannot use autocomplete after number
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox65 verified)
VERIFIED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | verified |
People
(Reporter: 709922234, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: [boogaloo-mvp])
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180729220222
Steps to reproduce:
1. Open the console
2. Type `(1).` or `1..`
Actual results:
autocompletion popup isn't displayed
Expected results:
show autocompletion popup
|
Assignee | |
Updated•7 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Whiteboard: [boogaloo-reserve]
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [boogaloo-reserve] → [boogaloo-mvp]
|
||
Updated•7 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 1•7 years ago
|
||
When provided a number literal, JsPropertyProvider would
not return anything.
This patch solves this issue by adding an if case for those
objects.
Numerous test cases are added in test_js_property_provider to
make sure we handle this as expected and that we don't have
false positives.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c3e48a9ed61
Handle Number literals in JsPropertyProvider; r=bgrins.
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Updated•7 years ago
|
Flags: qe-verify+
|
||
Comment 4•7 years ago
|
||
Reproduced the issue with 63.0a1 (2018-07-30).
Fix verified with 65.0b12 on Windows 10, macOS10.13.6, Ubuntu 18.04.
You need to log in
before you can comment on or make changes to this bug.
Description
•