1479366 - JsTerm cannot use autocomplete after number

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[709922234]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180729220222

Steps to reproduce:

1. Open the console
2. Type `(1).` or `1..`


Actual results:

autocompletion popup isn't displayed


Expected results:

show autocompletion popup

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1479366 - Handle Number literals in JsPropertyProvider; r?bgrins.

When provided a number literal, JsPropertyProvider would
not return anything.
This patch solves this issue by adding an if case for those
objects.
Numerous test cases are added in test_js_property_provider to
make sure we handle this as expected and that we don't have
false positives.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c3e48a9ed61
Handle Number literals in JsPropertyProvider; r=bgrins.

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1c3e48a9ed61

Comment 4

[Cristian Fogel [:cfogel]]

Reproduced the issue with 63.0a1 (2018-07-30).
Fix verified with 65.0b12 on Windows 10, macOS10.13.6, Ubuntu 18.04.