1479377 - Notification message when switching language in Preferences is empy

Status: VERIFIED FIXED

Description

[Francesco Lodolo [:flod]]

Attachment: Empty message

Installed French language pack on 63.0a1 (2018-07-29) (64 bit) (Italian), the language shows up in the list. When I try to switch, the restart message shows up empty, with "undefined" as button label.

If I restart and try to switch back to Italian, I see the message in Italian.

Comment 1

[:Gijs (he/him)]

Tracking for 63, so marking P1. Looks like an issue with the feature added in bug 1469684. Mark, can you take a look?

Comment 2

[Mark Striemer [:mstriemer]]

I believe this is because the target language doesn't have a translation for the string. We could put a fallback in place so that it will appear in English, or the current language, if the other language doesn't have a translation, I'm not sure what the correct route is here though.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Mark Striemer [:mstriemer] from comment #2)
> I believe this is because the target language doesn't have a translation for
> the string. We could put a fallback in place so that it will appear in
> English, or the current language, if the other language doesn't have a
> translation, I'm not sure what the correct route is here though.

That's likely the case, those strings are currently translated only in Italian and Dutch.

I think falling back to the current language would be OK in this case.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1479377 - Provide fallbacks for switch language in Prefs message

Review commit: https://reviewboard.mozilla.org/r/260324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260324/

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: switch-languages-fallback.mov

This will now fallback to the current locale, then the last fallback locale.

Comment 6

[Zibi Braniecki [:gandalf][:zibi]]

Comment on attachment 8996081 [details]
Bug 1479377 - Provide fallbacks for switch language in Prefs message

https://reviewboard.mozilla.org/r/260324/#review267402

Yeah!

::: browser/components/preferences/in-content/main.js:243
(Diff revision 1)
> -// Load the preferences string bundle for a given locale.
> +// Load the preferences string bundle for a given locale with fallbacks.
>  function getBundleForLocale(locale) {
> +  let locales = [locale, Services.locale.getRequestedLocale()];
> +  if (locales[1] != Services.locale.lastFallbackLocale) {
> +    locales.push(Services.locale.lastFallbackLocale);
> +  }

I'd go for: 
```
L10nRegistry.generateContexts(Array.from(new Set([
  locale,
  ...Services.locale.getRequestedLocales(),
  Services.locale.lastFallbackLocale
])), resourceIds);
```

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 8996081 [details]
Bug 1479377 - Provide fallbacks for switch language in Prefs message

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260324/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ef564f7ffe2
Provide fallbacks for switch language in Prefs message r=gandalf

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4ef564f7ffe2

Comment 10

[Francesco Lodolo [:flod]]

Verified on 63.0a1 (2018-07-31) (64 bit)