Closed Bug 1479424 Opened 2 years ago Closed 2 years ago

NotifyVSync not called on Firefox Reality when compositor is paused

Categories

(Core :: WebVR, defect)

Unspecified
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: imanol, Assigned: imanol)

Details

(Whiteboard: [geckoview:fxr:p1])

Attachments

(1 file)

Firefox Reality pauses the compositor when the WebVR presentation starts. That causes VRManager::NotifyVsync() not to be called.

VRManager::NotifyVsync() should be called constinuosly while the compositor is paused because Gecko WebVR Architecture also relies on that to act as a "watchdog" in order to avoid a render loop stalls and recover from SubmitFrame call timeouts.
Assignee: nobody → imanol
Whiteboard: [geckoview:fxr:p1]
Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267378

LGTM.  If we later pause the compositor on other platforms, we could find a more universal mechanism.  Until then, this should work fine.
Attachment #8996003 - Flags: review?(kgilbert) → review+
Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267384
Attachment #8996003 - Flags: review?(rbarker) → review+
Keywords: checkin-needed
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ced7ff6dd7cd
Fix VRManager NotifyVSync not called when compositor is paused on Android; r=kip,rbarker
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ced7ff6dd7cd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
status-firefox62=wontfix because we don't need to uplift this FxR fix to GV 62.
You need to log in before you can comment on or make changes to this bug.