NotifyVSync not called on Firefox Reality when compositor is paused

RESOLVED FIXED in Firefox 63

Status

()

defect
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: imanol, Assigned: imanol)

Tracking

unspecified
mozilla63
Unspecified
Android
Points:
---

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

Details

(Whiteboard: [geckoview:fxr:p1])

Attachments

(1 attachment)

Assignee

Description

10 months ago
Firefox Reality pauses the compositor when the WebVR presentation starts. That causes VRManager::NotifyVsync() not to be called.

VRManager::NotifyVsync() should be called constinuosly while the compositor is paused because Gecko WebVR Architecture also relies on that to act as a "watchdog" in order to avoid a render loop stalls and recover from SubmitFrame call timeouts.
Assignee

Updated

10 months ago
Assignee: nobody → imanol
Assignee

Updated

10 months ago
Whiteboard: [geckoview:fxr:p1]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267378

LGTM.  If we later pause the compositor on other platforms, we could find a more universal mechanism.  Until then, this should work fine.
Attachment #8996003 - Flags: review?(kgilbert) → review+

Comment 6

10 months ago
mozreview-review
Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267384
Attachment #8996003 - Flags: review?(rbarker) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

10 months ago
Keywords: checkin-needed
Comment hidden (mozreview-request)

Comment 10

10 months ago
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ced7ff6dd7cd
Fix VRManager NotifyVSync not called when compositor is paused on Android; r=kip,rbarker
Keywords: checkin-needed

Comment 11

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ced7ff6dd7cd
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
status-firefox62=wontfix because we don't need to uplift this FxR fix to GV 62.
You need to log in before you can comment on or make changes to this bug.