1479424 - NotifyVSync not called on Firefox Reality when compositor is paused

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Imanol Fernandez]

Firefox Reality pauses the compositor when the WebVR presentation starts. That causes VRManager::NotifyVsync() not to be called.

VRManager::NotifyVsync() should be called constinuosly while the compositor is paused because Gecko WebVR Architecture also relies on that to act as a "watchdog" in order to avoid a render loop stalls and recover from SubmitFrame call timeouts.

Comment 1

[Imanol Fernandez]

Attachment: Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review commit: https://reviewboard.mozilla.org/r/260282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260282/

Comment 2

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/1-2/

Comment 3

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/2-3/

Comment 4

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/3-4/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267378

LGTM.  If we later pause the compositor on other platforms, we could find a more universal mechanism.  Until then, this should work fine.

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

https://reviewboard.mozilla.org/r/260282/#review267384

Comment 7

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/4-5/

Comment 8

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/5-6/

Comment 9

[Imanol Fernandez]

Comment on attachment 8996003 [details]
Bug 1479424 - Fix VRManager NotifyVSync not called when compositor is paused on Android;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260282/diff/6-7/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ced7ff6dd7cd
Fix VRManager NotifyVSync not called when compositor is paused on Android; r=kip,rbarker

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ced7ff6dd7cd

Comment 12

[Chris Peterson [:cpeterson]]

status-firefox62=wontfix because we don't need to uplift this FxR fix to GV 62.