Closed
Bug 1479438
Opened 6 years ago
Closed 6 years ago
Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html
Categories
(Toolkit :: Safe Browsing, enhancement, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dlee, Assigned: dlee)
References
Details
Attachments
(1 file, 1 obsolete file)
While I was reviewing Bug 1461515, the local mochitest - test_privatebrowsing_trackingprotection.html test keeps failing. This is because we use the wrong resource URL, so it will fail if classifiedAnnotatedPBFrame.html is not generated.
|
||
Updated•6 years ago
|
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Priority: -- → P1
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
The path we were using for classifiedAnnotatedPBFrame.html will only exist if we have ever run a test case defined in mochitest.ini, which is fine in most case (Run a directory based mochitest command for example). Since test_privatebrowsing_trackingprotection.html is a chrome scope test case so we should change the path to the one generated when we run chrome.ini. I also remove classifiedAnnotatedPBFrame.html from mochitest.ini since it is not used by any other test case in mochitest.ini
|
||
Updated•6 years ago
|
Attachment #8996705 -
Attachment is obsolete: true
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8996028 [details] Bug 1479438 - Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r?francois François Marier [:francois] has approved the revision. https://phabricator.services.mozilla.com/D2512
Attachment #8996028 -
Flags: review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c24cbe66dcfaa478bd9059776a44db5217471b
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68ecfbb3f0a4 Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r=francois
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/68ecfbb3f0a4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•