1479438 - Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P1)

Description

[Dimi Lee [:dimi]]

While I was reviewing Bug 1461515, the local mochitest - test_privatebrowsing_trackingprotection.html test keeps failing.

This is because we use the wrong resource URL, so it will fail if classifiedAnnotatedPBFrame.html is not generated.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1479438 - Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r?francois

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1479438 - Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r?francois

The path we were using for classifiedAnnotatedPBFrame.html will only exist if
we have ever run a test case defined in mochitest.ini, which is fine in most case
(Run a directory based mochitest command for example).

Since test_privatebrowsing_trackingprotection.html is a chrome scope test case so
we should change the path to the one generated when we run chrome.ini.

I also remove classifiedAnnotatedPBFrame.html from mochitest.ini since it is not
used by any other test case in mochitest.ini

Comment 3

[Phabricator Automation]

Comment on attachment 8996028 [details]
Bug 1479438 - Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r?francois

François Marier [:francois] has approved the revision.

https://phabricator.services.mozilla.com/D2512

Comment 4

[Dimi Lee [:dimi]]

try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c24cbe66dcfaa478bd9059776a44db5217471b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ecfbb3f0a4
Use correct resource url for chrome scope test_privatebrowsing_trackingprotection.html. r=francois

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/68ecfbb3f0a4