Closed
Bug 1479465
Opened 7 years ago
Closed 7 years ago
Implement ref.eq on anyref and ref T (without eqref)
Categories
(Core :: JavaScript: WebAssembly, enhancement, P3)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.21 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
For the time being it's fine to support ref.eq on all reference types, we don't have to wait for eqref for this, and eqref is complicated.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8995993 -
Attachment is obsolete: true
Attachment #9008008 -
Flags: review?(luke)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 9008008 [details] [diff] [review]
bug1479465-ref-eq-on-all-reftypes-v2.patch
Review of attachment 9008008 [details] [diff] [review]:
-----------------------------------------------------------------
Great, makes sense.
::: js/src/wasm/WasmBaselineCompile.cpp
@@ +7256,5 @@
> #endif
>
> + // No optimization for pointer compares yet.
> + if (operandType.isRefOrAnyRef())
> + return false;
nit: (to reuse your pun) embrace the new style overlords
Attachment #9008008 -
Flags: review?(luke) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71ded3ad0ed4
ref.eq on all wasm reference types. r=luke
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•