Implement ref.eq on anyref and ref T (without eqref)

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 months ago
For the time being it's fine to support ref.eq on all reference types, we don't have to wait for eqref for this, and eqref is complicated.
(Assignee)

Comment 1

9 months ago
(Assignee)

Comment 2

7 months ago
Attachment #8995993 - Attachment is obsolete: true
Attachment #9008008 - Flags: review?(luke)
Comment on attachment 9008008 [details] [diff] [review]
bug1479465-ref-eq-on-all-reftypes-v2.patch

Review of attachment 9008008 [details] [diff] [review]:
-----------------------------------------------------------------

Great, makes sense.

::: js/src/wasm/WasmBaselineCompile.cpp
@@ +7256,5 @@
>  #endif
>  
> +    // No optimization for pointer compares yet.
> +    if (operandType.isRefOrAnyRef())
> +        return false;

nit: (to reuse your pun) embrace the new style overlords
Attachment #9008008 - Flags: review?(luke) → review+

Comment 4

7 months ago
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71ded3ad0ed4
ref.eq on all wasm reference types. r=luke

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/71ded3ad0ed4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.