1479528 - More frame construction bits while I wrap my head about the best way to fix bug 1476281

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

The title :)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Split a bit more AddFrameConstructionItemsInternal.

Hopefully making it a bit easier to follow. I tried to move all the XBL
weirdness away, but this is the best I could make it :(

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Remove FrameConstructionItem::mIsForSVGAElement.

It was needed presumably because XBL could override the tag name and what not.
But I removed that capability for elements other than XUL elements, so we can
just poke at the content directly.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Remove FrameConstructionItem::mHasInlineEnds.

It's write-only.

Comment 4

[Phabricator Automation]

Comment on attachment 8996037 [details]
Remove FrameConstructionItem::mHasInlineEnds.

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2521

Comment 5

[Phabricator Automation]

Comment on attachment 8996034 [details]
Remove FrameConstructionItem::mIsForSVGAElement.

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2520

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Make the ShouldSuppressFrameIn* functions take references.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Move the XBL binding loads a bit more away.

They're pretty ugly...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Move all the data-finding related stuff into a single function.

To make it hopefully a bit easier to follow.

Comment 9

[Phabricator Automation]

Comment on attachment 8996286 [details]
Make the ShouldSuppressFrameIn* functions take references.

Daniel Holbert [:dholbert] has approved the revision.

https://phabricator.services.mozilla.com/D2562

Comment 10

[Phabricator Automation]

Comment on attachment 8996290 [details]
Move all the data-finding related stuff into a single function.

Daniel Holbert [:dholbert] has approved the revision.

https://phabricator.services.mozilla.com/D2564

Comment 11

[Phabricator Automation]

Comment on attachment 8996289 [details]
Move the XBL binding loads a bit more away.

Daniel Holbert [:dholbert] has approved the revision.

https://phabricator.services.mozilla.com/D2563

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd23a7207dbb
Make the ShouldSuppressFrameIn* functions take references. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/935ad68fc5db
Move the XBL binding loads a bit more away. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/5947eab03924
Move all the data-finding related stuff into a single function. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/c84a0cd61b68
Remove FrameConstructionItem::mIsForSVGAElement. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3fbb65156c3
Remove FrameConstructionItem::mHasInlineEnds. r=bz

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cd23a7207dbb
https://hg.mozilla.org/mozilla-central/rev/935ad68fc5db
https://hg.mozilla.org/mozilla-central/rev/5947eab03924
https://hg.mozilla.org/mozilla-central/rev/c84a0cd61b68
https://hg.mozilla.org/mozilla-central/rev/b3fbb65156c3