1479631 - Fix media.memory_caches_combined_limit_kb value on Android

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Nicholas Nethercote [inactive]]

It was accidentally changed from 524288 to 32768 on Android by bug 1448222.
This commit changes it back.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Fix media.memory_caches_combined_limit_kb value on Android

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8996153 [details] [diff] [review]
Fix media.memory_caches_combined_limit_kb value on Android

Review of attachment 8996153 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8ba2d6bd35
Fix media.memory_caches_combined_limit_kb value on Android. r=drno

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8996153 [details] [diff] [review]
Fix media.memory_caches_combined_limit_kb value on Android

Approval Request Comment

[Feature/Bug causing the regression]: Bug 1448222 (Firefox 61).

[User impact if declined]: Android users get the wrong value for the media.memory_caches_combined_limit_kb pref.

[Is this code covered by automated tests?]: Not sure.

[Has the fix been verified in Nightly?]: No.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None.

[Is the change risky?]: No.

[Why is the change risky/not risky?]: It reverts the value of a single pref to what it was in Firefox 60 (and earlier versions).

[String changes made/needed]: None.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4d8ba2d6bd35

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8996153 [details] [diff] [review]
Fix media.memory_caches_combined_limit_kb value on Android

Fixes a recent regression, Beta62+

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/60840467a49e