Saving a pdf page to pocket while in presentation mode breaks the "Page actions" and "Save to pocket" buttons

ASSIGNED
Assigned to

Status

()

defect
P3
normal
ASSIGNED
Last year
3 months ago

People

(Reporter: emilghitta, Assigned: adw)

Tracking

({regression})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox61 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 fix-optional)

Details

Attachments

(1 attachment)

Posted image Save to pocket.gif
[Affected versions]:
63.0a1 (BuildId:20180730221422)
62.0b13 (BuildId:20180730180407)
61.0.1 (BuildId:20180704003137)
60.1.0esr (BuildId:20180621121604)

[Affected platforms]:
Windows 7 64bit.
macOS 10.10.
Ubuntu 16.04 32bit.

[Steps to reproduce]:
1. Launch Firefox.
2. Access the following link:https://cdn4.libris.ro/userdocspdf/589/faust.pdf. 
3. Switch to Presentation Mode.
4. Right click and select the "Save Page to Pocket" option.
5. Click on the "Page actions" and "Save to Pocket" buttons.

[Expected result]:
The "Page actions" and "Save to pocket" buttons are functional.

[Actual result]:
The buttons are not functional and the following error gets fired in the Browser Console each time the "Page actions" button is pressed: "TypeError: panelNode.anchorNode is null"

[Regression range]:
This seems to be a regression:

Last good revision: 7f19b2c7adc598f40bf32808324bcba463cce627
First bad revision: 9f83f552a6118f1061ee5afd87578d9b5b82b308
 
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f19b2c7adc598f40bf32808324bcba463cce627&tochange=9f83f552a6118f1061ee5afd87578d9b5b82b308

[Note]
A workaround for this is to restart Firefox or to open a New Browser Window.

For further information regarding this issue please observe the attached screencast.
Hi Drew, 

It seems that mozregression pointed out Bug 1395387 for causing this regression.

Can you please have a look?

Thanks!
Flags: needinfo?(adw)
Component: PDF Viewer → Toolbars and Customization
Flags: needinfo?(adw)
Assignee: nobody → adw
Status: NEW → ASSIGNED
Priority: -- → P3
Too late for 63 but we could still potentially take a fix in 64/65.
Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.

Reproduced on latest Nightly 68.0a1 (2019-03-31) (64-bit) on Ubuntu 16.04 x64

You need to log in before you can comment on or make changes to this bug.