setCharsetForURI should use history.update

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P2
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: mak, Assigned: standard8)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(2 attachments)

this is one of the remaining uses of the page annotations API
(Assignee)

Updated

9 months ago
Assignee: nobody → standard8
Status: NEW → ASSIGNED
(Assignee)

Updated

9 months ago
Depends on: 1479764
Comment on attachment 8996468 [details]
Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2582
Attachment #8996468 - Flags: review+
Comment on attachment 8996470 [details]
Bug 1479722 - Remove nsIAnnotationService::setPageAnnotation and removePageAnnotation.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2583
Attachment #8996470 - Flags: review+
(Assignee)

Updated

9 months ago
Blocks: 1480049

Comment 6

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26c498b422eb
Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak

Comment 7

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fde7e80c27a7
Remove nsIAnnotationService::setPageAnnotation and removePageAnnotation. r=mak
Is the charset information still needed in the history? The only remaining user is keyword bookmarks. How about adding charset to moz_keywords instead of annotations?
(In reply to Masatoshi Kimura [:emk] from comment #8)
> Is the charset information still needed in the history? The only remaining
> user is keyword bookmarks. How about adding charset to moz_keywords instead
> of annotations?

It's indeed an interesting suggestion that I thought about time ago too, once we have an abstraction we can do anything.
There are 2 problems there:
1. we don't know if the user will add a keyword to a bookmark at a later time, thus we have to store the charset regardless
2. the user can still force a charset for a page through the main menubar (though I'm not sure if that info is still used properly)

I think we should see if bug 648398 goes anywhere, anyway it should not be a big deal to keep things as they are for a while.

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26c498b422eb
https://hg.mozilla.org/mozilla-central/rev/fde7e80c27a7
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.