1479728 - GeckoViewNavigation.jsm uses unknown property Ci.nsIWebNavigation.LOAD_FLAGS_EXTERNAL

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Mark Banner (:standard8)]

In finding properties/constants of idl interfaces that aren't valid I discovered this:

mobile/android/modules/geckoview/GeckoViewNavigation.jsm
  69:23  error  Use of unknown property Ci.nsIWebNavigation.LOAD_FLAGS_EXTERNAL

There's also a comment in the file:

```
// These need to match the values in GeckoSession.LOAD_TYPE_*
```

This seems out of date, as I can't see any LOAD_TYPE_* relating to GeckoSession.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

The nsIWebNavigation flag should be LOAD_FLAGS_FROM_EXTERNAL.

Comment 2

[Chris Peterson [:cpeterson]]

When we fix this bug, we should make sure GV apps (like Focus and FxR) set this flag when opening pages from external apps.

Comment 3

[Mark Banner (:standard8)]

James, are you still working on this? Would be nice just to cross off the list at some stage.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

I haven't worked on this but it's an easy fix. I'll put a patch up.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1479728 - Fix loading with `GeckoSession.LOAD_FLAGS_EXTERNAL`

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f5221d3b83b
Fix loading with `GeckoSession.LOAD_FLAGS_EXTERNAL` r=geckoview-reviewers,agi

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/0f5221d3b83b