1479758 - <kbd>⌘</kbd>+<kbd>↑</kbd> does not navigate the console input history when cursor at the beginning of the input

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

**Steps to reproduce**
1. Open the console
2. Evaluate `1 + 1`
3. Hit <kbd>⌘</kbd>+<kbd>↑</kbd>


**Expected results**

I navigate the input to the `1 + 1` entry

**Actual results**

The input stays empty
---

In old jsterm I used to use <kbd>⌘</kbd>+<kbd>↑</kbd> to quickly navigate between multiline entries (it goes to the very top of the input first, then the second stroke would navigate). We should ensure to handle this (as well as <kbd>⌘</kbd>+<kbd>↓</kbd> , since it does not work either).

Comment 1

[Brian Grinstead [:bgrins]]

Makes sense. I've also thought about having a shortcut that would navigates through immediately regardless of cursor position. Know of any prior art for that?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

That means more shortcut :)
I know gmail has vim-like binding to navigate through the message list (K-J), but I don't know if there are safe to use in the console. 
Also, that might confuse people used to vim by making them navigate the history when they want to only move the cursor up/down.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

it may be plain better to have previous/next button to the right of the input so you can navigate more easily
could work very well with reverse search as well if people don't know how to cycle through results

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Blocking on Bug 1479521 since the code changes quite a bit there.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1479758 - Enable history navigation with Cmd/Ctrl ArrowUp/Down; r=bgrins.

Matches old-JsTerm behavior.

Depends on D2824

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8999551 [details]
Bug 1479758 - Enable history navigation with Cmd/Ctrl ArrowUp/Down; r=bgrins.

Brian Grinstead [:bgrins] has approved the revision.

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8999551 [details]
Bug 1479758 - Enable history navigation with Cmd/Ctrl ArrowUp/Down; r=bgrins.

Brian Grinstead [:bgrins] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93031405a2de
Enable history navigation with Cmd/Ctrl ArrowUp/Down; r=bgrins.

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/93031405a2de