1479857 - Add a preference (default on) for autoconfig sanboxing for first release

Status: VERIFIED FIXED

(Core :: AutoConfig (Mission Control Desktop), defect)

Description

[:shell escalante]

Since this is is a release only feature. All other builds (beta, dev edition, nightly, esr) will not sandbox Autoconfig.  Which means we have not had this ride "the trains".

The way it stands now, once it's done, it can't be turned off. We should use a pref to turn it on for a release or two just in case (similar to what we did with extension signing). 


Putting this behind a pref, default on is the low risk way to get land sandboxing autoconfig in 62.

* after a couple of Releases nothing major has happened, we can remove the pref.  
* If something goes wrong, it won't require a dot release to flip the pref to disable the sandboxing.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: First pass

Simple change for the default and then display a deprecation message if parsing fails.

We're like to get an enterprise release notes page we can link to.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1479857 - Use pref for Autoconfig on release, off by default

Comment 3

[Phabricator Automation]

Comment on attachment 8998016 [details]
Bug 1479857 - Use pref for Autoconfig on release, off by default

Kris Maglione [:kmag] has approved the revision.

https://phabricator.services.mozilla.com/D2801

Comment 4

[:shell escalante]

tagged this for the 62 branch

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking as a blocker so we will make sure to land this on beta before release.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68d89e639065
Use pref for Autoconfig on release, off by default r=kmag

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/68d89e639065

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 8998016 [details]
Bug 1479857 - Use pref for Autoconfig on release, off by default

Approval Request Comment
[Feature/Bug causing the regression]: Use a pref to turn autoconfig off in beta/release
[User impact if declined]: None
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No. This is a beta change and QA is ready to verify.
[Needs manual test from QE? If yes, steps to reproduce]: Yes, they have the information already (as part of test plan)
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Very low
[Why is the change risky/not risky?]: Adds pref around already turned off feature.
[String changes made/needed]:

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8998016 [details]
Bug 1479857 - Use pref for Autoconfig on release, off by default

Let's verify in beta; should land for this week's beta 19 build.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0650cf336ae5

Comment 11

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 0650cf336ae5 (bug 1479857) for suspicion of causing talos tp6 and h2 failures.

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/db5f926d5cdc05d01edcdf2d264fd50ca4ec6720

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=e8db9f7d2225366699c4c2c73d1d4ab465700253&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=194054391

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194054391&repo=mozilla-beta&lineNumber=1024

Comment 12

[Mike Kaply [:mkaply]]

Was this definitely the reason for the failure? I don't understand how this could cause any of these failure. This code does nothing if there is no autoconfig file.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Yes, the failures went away with the backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&tochange=db5f926d5cdc05d01edcdf2d264fd50ca4ec6720&filter-searchStr=tp6&fromchange=e911e6f9571b0a31d819bf2a1aa019d166210ab4

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This relanded: https://hg.mozilla.org/releases/mozilla-beta/rev/b1c0bbcc4195b059ec7dc9e1219b63a08a78c5af
And got backed out again for the same issue: https://hg.mozilla.org/releases/mozilla-beta/rev/7aca2ef5be9ca8d696db98dd6fd915ebaf69b707

Comment 15

[Mike Kaply [:mkaply]]

That's really confusing.

It didn't happen in a try build.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad72156639084ad03ffe5ac9d25f6fe368e46f52

I'll run some local tests.

Comment 16

[Masatoshi Kimura [:emk]]

Wow, Talos depends on non-sandboxed autoconfig:
https://dxr.mozilla.org/mozilla-central/rev/4e56a2f51ad739ca52046723448f3129a58f1666/testing/talos/talos/mitmproxy/mitmproxy.py#59
https://dxr.mozilla.org/mozilla-central/rev/4e56a2f51ad739ca52046723448f3129a58f1666/testing/talos/talos/mitmproxy/mitmproxy.py#28

So it will not happen on Nightly nor local builds.

Comment 17

[Mike Kaply [:mkaply]]

> Wow, Talos depends on non-sandboxed autoconfig:

Thank you for finding this!

It's a good thing we found this now. This would have broke when we moved to release and we would have had no idea why.

For now, I'm going to add the sandbox pref, but we have to find a solution to this before we remove the pref.

Comment 18

[Mike Kaply [:mkaply]]

Attachment: Fix to talos

This is the talos fix.

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4df089dd0c1a

Comment 20

[Eliza Balazs [:ebalazs_]]

Hi,the patch needs to land else it will fail when the code moves to beta.

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=587dd308797a67580077316ce6da6be6a9afbff9&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=194299043&filter-searchStr=tp6

Comment 21

[Intermittent Failures Robot]

38 failures in 2672 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 38

Platform breakdown:
* linux64: 5
* windows7-32-msvc: 2
* windows10-64-qr: 2
* windows7-32: 2
* macosx64-nightly: 4
* linux64-qr: 6
* windows10-64: 2
* linux64-nightly: 5
* windows10-64-msvc: 2
* osx-10-10: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1479857&startday=2018-08-13&endday=2018-08-19&tree=all

Comment 22

[Mike Kaply [:mkaply]]

Attachment: Bug 1479857 - Enable Autoconfig sandbox for Talos.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d5e2c4f446b
Enable Autoconfig sandbox for Talos. r=RyanVM

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9002840 [details]
Bug 1479857 - Enable Autoconfig sandbox for Talos.

Ryan VanderMeulen [:RyanVM] has approved the revision.

Comment 25

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0d5e2c4f446b

Comment 26

[Mike Kaply [:mkaply]]

Landed on central.

Comment 27

[Intermittent Failures Robot]

18 failures in 2568 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 18

Platform breakdown:
* linux64: 6
* macosx64-nightly: 1
* osx-10-10: 4
* linux64-qr: 6
* linux64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1479857&startday=2018-08-20&endday=2018-08-26&tree=all

Comment 28

[Cristian Baica [:cbaica], Release Desktop QA]

This bug was covered by the overall manual testing efforts invested in the Sandbox AutoConfig feature. The uplift didn't break any existing or implemented functionality.

Marking this as verified fixed using Fx 62.0b20 on Windows 10 x64 and macOS 10.13.4.